Exception on invalid timestamp format

this concerns exe's compiled with MSVC *NOT* MinGW

I can confirm this, using the latest BCDC++ build compiled with MSVC.

This reminds me that I always wanted to know how to avoid problems when formatting string for functions printf, strftime etc. can be set by users. This bug is one case of it.

if i remember correctly, the solution to this is to set up an exception handler that doesn't re-throw the exception, using SetUnhandledExceptionFilter: <http://msdn.microsoft.com/en-us/library/ms680634(VS.85).aspx>

I think this is what we need - http://msdn.microsoft.com/en-us/library/ksazx244(v=VS.90).aspx

Or just use boost::format and handle the caught exception instead of some C or windows specific libraries. We already use boost::format for i18n, why not everything else?

http://live.boost.org/doc/libs/1_34_0/libs/format/doc/format.html#exceptions

I'm guessing this is for timestamps (strftime) so boost::format won't work...

geez, that's a thoroughly stupid way of handling an invalid time string - crashing the application...I vote for bigmuscles solution =) specially since it will do the right thing if the format string is bad - set errno and return 0.

still crashes here.

Will use the previously mentioned handler, and will be tested when the dialog is closed. When an error occur, it will reset to the previous formatting.

this should be done in the formatting function in dcpp::Util, which can throw this on more than just invalid timestamps. it can for example happen with bad parameters in user commands or in log file definitions.

i am reticent in adding this since it only affects a secondary compiler, but can be convinced if the patch is inconspicuous enough.

When/If VS2015 is supported we should update this to use _set_thread_local_invalid_parameter_handler instead per <https://msdn.microsoft.com/en-us/library/a9yf33zb(v=vs.140).aspx>