Mixxx

Gradient background in Waveform display

Bug #677448 reported by jus on 2010-11-19

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Mixxx	Fix Released	Low	RJ Skerry-Ryan	Mixxx 1.10.0

Bug Description

I have a hard time to understand what the hardcoded gradient background in the waveform display is good for.

* It is not used for the default skin ( and all other skins with #000000 background colour)
* Makes it hard to choose a colour for (Hot)-cue, Loop-Marker & Loop -Overlay
* Visibility for the waveform is limited cause of the diffuse contrast with background, marker & overlay
* It eats CPU and looks somewhat bad

There might be a reason for the gradient i don`t know about but if not my vote goes for the gradients complete removal.

Related branches

lp://staging/~mixxxdevelopers/mixxx/trunk

Revision history for this message

RJ Skerry-Ryan (rryan) wrote on 2011-03-07:

to replace it, should I add support for a background color, and optionally a background image?

Changed in mixxx:
status:	New → Confirmed
importance:	Undecided → Low
assignee:	nobody → RJ Ryan (rryan)
milestone:	none → 1.9.1

Revision history for this message

jus (jus) wrote on 2011-03-08:

This, just like it is for (Hot)-cues.
And can we do it for the waveform overview too?

Will update the skins then later on and attach a patch here.

Q:
Is there a way to make a patch in bzr that includes images ?
When i use my standard "bzr diff > feature.patch " there is only a reference to the images.
I copied the images in the respective folders manually until.

RJ Skerry-Ryan (rryan) on 2011-03-08

Changed in mixxx:
milestone:	1.9.1 → 1.10.0

Revision history for this message

RJ Skerry-Ryan (rryan) wrote on 2011-03-26:

Done now. All waveforms will have a solid color that is the same as what is in the <BgColor> tag of the <Visual> block.

Added a <BgPixmap> option to the <Visual> group as well. It loads the pixmap and will tile it in the x or y direction if it is not the full width or height of the waveform widget.

Changed in mixxx:
status:	Confirmed → Fix Committed

Revision history for this message

RJ Skerry-Ryan (rryan) wrote on 2011-03-26:

overview-waveform-tiling.png Edit (262.7 KiB, image/png)

And as to your question about the overviews, <Overview> already obeyed <BgColor> and now I've added support for <BgPixmap> as well. See attached image -- it looks pretty strange with my test image, but it works :)

Revision history for this message

jus (jus) wrote on 2011-03-26:

Thanks, for this.
This gradient background ticked me off so badly :-)

And who likes can go full retro and insert a gradient <BgPixmap>.

RJ Skerry-Ryan (rryan) on 2011-12-25