Make reduce_js an optional argument to CouchDatabaseBase.add_view
Bug #675616 reported by
Eric Casteleijn
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| desktopcouch |
Fix Released
|
Low
|
Eric Casteleijn | ||
| desktopcouch (Ubuntu) |
Fix Released
|
Low
|
Eric Casteleijn | ||
Bug Description
Since a lot of views don't include reduction steps, it is silly to require them to pass in an empty string for this argument. Let's make it a keyword argument with a default value of None and then not add any reduce key to the view dictionary at all if it's not passed in.
Related branches
lp://staging/~thisfred/desktopcouch/optional-reduce
- Vincenzo Di Somma (community): Approve
- Chad Miller (community): Approve
-
Diff: 491 lines (+94/-65)10 files modifieddesktopcouch/contacts/view.py (+18/-11)
desktopcouch/pair/couchdb_pairing/couchdb_io.py (+1/-1)
desktopcouch/pair/couchdb_pairing/ubuntuone_pairing.py (+5/-2)
desktopcouch/pair/tests/test_ubuntuone_pairing.py (+9/-7)
desktopcouch/records/doc/records.txt (+1/-2)
desktopcouch/records/server_base.py (+3/-5)
desktopcouch/records/tests/test_server.py (+5/-4)
desktopcouch/start_local_couchdb.py (+33/-21)
desktopcouch/tests/test_start_local_couchdb.py (+18/-11)
utilities/lint.sh (+1/-1)
| Changed in desktopcouch: | |
| status: | Triaged → In Progress |
| Changed in desktopcouch: | |
| status: | In Progress → Fix Committed |
| Changed in desktopcouch (Ubuntu): | |
| assignee: | nobody → Eric Casteleijn (thisfred) |
| status: | New → In Progress |
| importance: | Undecided → Low |
| milestone: | none → natty-alpha-1 |
| Changed in desktopcouch (Ubuntu): | |
| milestone: | natty-alpha-1 → natty-alpha-2 |
| Changed in desktopcouch: | |
| status: | Fix Committed → Fix Released |
| Changed in desktopcouch (Ubuntu): | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
