Version model seems unnecessary
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ratings and Reviews server |
Fix Released
|
Medium
|
Danny Tamez |
Bug Description
Anthony said:
"Is Version really needed? It would seem that instead of
Review --> SoftwareItem
|
v
Version
we might want
Review --> SoftwareInARepo
(+version) --> SoftwareItem
... where SoftwareRelease is a versioned SoftwareItem, with a
unique constraint over the softwareitem + version attributes, or
something.
"
Personally, I'm not sure why we don't simply have version as an attribute on the Review model? This would enable us to return all reviews for a given software item, or reviews for specific versions. Possibly even reviews where the version is greater than X (if we use the postgresql debversion package http://
Changed in rnr-server: | |
assignee: | nobody → Danny Tamez (zematynnad) |
status: | Confirmed → In Progress |
Changed in rnr-server: | |
status: | In Progress → Fix Committed |
tags: | added: kb-defect |
tags: | added: qa-untestable |
Changed in rnr-server: | |
status: | Fix Committed → Fix Released |
Changed in rnr-server: | |
milestone: | none → 11.01 |
Changed in rnr-server: | |
milestone: | 11.01 → 10.12 |
Having a version attribute would imply many many copies of each version string stored in the database, one with each review. I think this could work if there isn't a list of available versions we can check, and we just need to believe the user when a vote is submitted about what version they're reviewing, but even then we could create a new SoftwareRelease (per ascii art above) on demand if somebody submits a review for a version we didn't have so far.