Mixxx

New hotcues need scripting on Hercules Mk2

Bug #665714 reported by iltony on 2010-10-23

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Mixxx	Fix Released	Wishlist	William Good	Mixxx 1.9.0
	1.8	Won't Fix	Wishlist	iltony	Mixxx 1.8.2

Bug Description

Hotcues work great through mixxx interface, but no midi mapping exists yet for Hercules Mk2. I propose to enable them through the attached patch in the script "Hercules-DJ-Console-Mk2-scripts.js" located under "/usr/local/share/mixxx/midi". My script is organized so that:

1.(in cue mode) each button is assigned to 1,2,3 hotcue
2. if first hotcue is no set, when users release button 1 a new hotcue is created
3. when 1 is pressed again, the playback seeks to hotcue 1
4. when 1 is long-pressed (more than half a second), first hotcue is cleared

Proposed patch works great on mixxx.1.8.x,
Antonio

Related branches

lp://staging/mixxx/1.9 (Merged)

Revision history for this message

iltony (iltony) wrote on 2010-10-23:

hotcues-4-hercules-Mk2-iltonys.patch Edit (2.3 KiB, text/plain)

Revision history for this message

William Good (bkgood) wrote on 2011-01-01:

Hi iltony,
Thanks for the patch! I just committed it to lp:mixxx/1.9. I noticed what I thought might be a bug, it looked like the timers used to detect when to delete weren't deck-specific, so I tried to make them so. Specifically, I added [Channel1] and [Channel2] indices to curLastDate{1,2,3}. Would you mind trying this out and making sure it works for me (I don't have the controller)? I'd like to have this confirmed working by release of 1.9.

Bill

Changed in mixxx:
status:	New → Fix Committed
importance:	Undecided → Wishlist
assignee:	nobody → iltony (iltony)
milestone:	none → 1.9.0
assignee:	iltony (iltony) → Bill Good (bkgood)

Revision history for this message

iltony (iltony) wrote on 2011-01-02:

scons-ing right now.

Revision history for this message

iltony (iltony) wrote on 2011-01-02:

Great. This new feature works fine in mixxx 1.9.0 branch with a Hercules Mk2! Now I'm thinking about adding other features as well: switching between "master tempo" and "pitch" mode, and a "reset pitch value" switch (might it be a good idea to associate this last action with a contemporary press of both pitch bend up and pitch bend down?) , but the main ones are there. Nice work btw! Quite impressed by this later improved library.

RJ Skerry-Ryan (rryan) on 2011-02-20