Odoo Server (MOVED TO GITHUB)

Confirm messages in buttons are not exported in .pot to translate (v 5.0 and 6.0)

Bug #663775 reported by Jordi Esteve (www.zikzakmedia.com) on 2010-10-20

This bug affects 4 people

Affects		Status	Importance	Assigned to	Milestone
	Odoo Server (MOVED TO GITHUB)	Fix Released	Medium	OpenERP's Framework R&D	Odoo Server (MOVED TO GITHUB) 6.0-rc2
	5.0	Fix Released	Low	Jay Vora (Serpent Consulting Services)	Odoo Server (MOVED TO GITHUB) 5.0.16

Bug Description

Confirm messages in buttons are not exported in .pot files, so they can not be translated. It affects v 5.0 and 6.0.

They are used in account_voucher and stock modules, for example:

Tags:

Related branches

lp://staging/openobject-server

lp://staging/openobject-server/5.0

Jordi Esteve (www.zikzakmedia.com) (jesteve-zikzakmedia) on 2010-10-20

affects:

openobject-addons → openobject-server

Olivier Dony (Odoo) (odo-openerp) on 2010-10-26

Changed in openobject-server:
assignee:	nobody → OpenERP's Framework R&D (openerp-dev-framework)
importance:	Undecided → Medium
milestone:	none → 6.0-rc2
status:	New → Triaged

Revision history for this message

Margarita Manterola (marga) wrote on 2010-11-08:

Exports the confirm message and translates it Edit (1.8 KiB, text/plain)

I experienced this bug and since I was in serious need of translation, I went ahead and patched my server. I'm attaching the diff. I'd appreciate if this could be applied to both v5 and v6.

Thanks!

Revision history for this message

Olivier Dony (Odoo) (odo-openerp) wrote on 2010-11-23:

Hello Jordi and Manterola,

Thanks for the patch!
We will definitely fix it on trunk for 6.0, and we'll see with the "stable" team if they think this issue is important enough and low-risk enough to apply on 5.0

Changed in openobject-server:
status:	Triaged → Confirmed

gpa(OpenERP) (gpa-openerp) on 2010-11-23

Changed in openobject-server:
status:	Confirmed → In Progress

Revision history for this message

Olivier Dony (Odoo) (odo-openerp) wrote on 2010-11-30:

Thank you for the patch, Margarita!
It has been applied in trunk with revision 3055 <email address hidden>

For 5.0, I will ask the stable team of they would consider applying the same fix or if it doesn't qualify for inclusion in a stable release.

Changed in openobject-server:
status:	In Progress → Fix Released

Revision history for this message

Olivier Dony (Odoo) (odo-openerp) wrote on 2010-11-30:

Jay, I'm re-targetting to 5.0 and assigning to you, in case you consider this fix worth including in a 5.0. I think it's quite low-risk, but it's far from blocking indeed.

tags:

added: maintenance

Revision history for this message

Jay Vora (Serpent Consulting Services) (jayvora) wrote on 2010-12-31:

Margarita Manterola ,

Thanks for the patch.
It has been fixed by revision 2167 <email address hidden> authored to you.