Launchpad itself

getBugNotificationsRecipients() has been superceded

Bug #659085 reported by Gavin Panella
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Gavin Panella
Launchpad itself 10.11 "Tenacious Turkey"

Bug Description

This has been replaced by IStructuralSubscriptionTarget.getSubscriptionsForBugTask() and, a level up, IBug.getStructuralSubscribers(). In fixing this bug it may be worth moving some of the behaviour of IBug.getStructuralSubscribers() into IBugTask.

Related branches

lp://staging/~allenap/launchpad/ditch-get-bug-notifications-recipients-bug-659085
Graham Binns (community): Approve (code)
Diff: 2497 lines (+1153/-1028)
19 files modified
lib/lp/bugs/configure.zcml (+0/-1)
lib/lp/bugs/doc/bugtask-search.txt (+1/-1)
lib/lp/bugs/interfaces/bug.py (+0/-6)
lib/lp/bugs/interfaces/bugtask.py (+6/-0)
lib/lp/bugs/model/bug.py (+5/-59)
lib/lp/bugs/model/bugtask.py (+61/-1)
lib/lp/bugs/model/tests/test_bug.py (+0/-85)
lib/lp/bugs/model/tests/test_bugtask.py (+442/-2)
lib/lp/bugs/model/tests/test_bugtask_status.py (+356/-0)
lib/lp/bugs/stories/bugs/xx-bugs-advanced-search-upstream-status.txt (+5/-5)
lib/lp/bugs/subscribers/bug.py (+7/-12)
lib/lp/bugs/tests/test_bugtask_0.py (+0/-36)
lib/lp/bugs/tests/test_bugtask_1.py (+0/-345)
lib/lp/bugs/tests/test_bugtask_status.py (+0/-356)
lib/lp/code/interfaces/branchmergequeue.py (+115/-0)
lib/lp/code/model/tests/test_branchmergequeue.py (+155/-0)
lib/lp/registry/doc/structural-subscriptions.txt (+0/-87)
lib/lp/registry/interfaces/structuralsubscription.py (+0/-14)
lib/lp/registry/model/structuralsubscription.py (+0/-18)
lp://staging/~allenap/launchpad/ditch-get-bug-notifications-recipients-bug-659085-devel
Henning Eggers (community): Approve (code)
Diff: 1526 lines (+525/-698)
15 files modified
lib/lp/bugs/configure.zcml (+0/-1)
lib/lp/bugs/doc/bugtask-search.txt (+1/-1)
lib/lp/bugs/interfaces/bug.py (+0/-7)
lib/lp/bugs/interfaces/bugtask.py (+6/-0)
lib/lp/bugs/model/bug.py (+5/-60)
lib/lp/bugs/model/bugtask.py (+59/-1)
lib/lp/bugs/model/tests/test_bug.py (+0/-85)
lib/lp/bugs/model/tests/test_bugtask.py (+442/-2)
lib/lp/bugs/stories/bugs/xx-bugs-advanced-search-upstream-status.txt (+5/-5)
lib/lp/bugs/subscribers/bug.py (+7/-12)
lib/lp/bugs/tests/test_bugtask_0.py (+0/-36)
lib/lp/bugs/tests/test_bugtask_1.py (+0/-345)
lib/lp/registry/doc/structural-subscriptions.txt (+0/-111)
lib/lp/registry/interfaces/structuralsubscription.py (+0/-14)
lib/lp/registry/model/structuralsubscription.py (+0/-18)
Gavin Panella (allenap)
Changed in malone:
assignee: nobody → Gavin Panella (allenap)
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r11794 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11794>.

Changed in malone:
milestone: 10.10 → 10.11
tags: added: qa-needstesting
Changed in malone:
status: In Progress → Fix Committed
Revision history for this message
Robert Collins (lifeless) wrote :

Mail for bugs does not seem to be getting sent from qastaging/staging at the moment. This /may/ be the cause.

tags: added: bad-commit-11794 qa-bad
removed: qa-needstesting
Revision history for this message
Deryck Hodge (deryck) wrote :

I just did some work on qa-staging, had mthaddon run ./cronscripts/send-bug-notifications.py, and got mail in the staging imap box just fine. This change is fine it seems to me.

tags: added: qa-ok
removed: bad-commit-11794 qa-bad
Robert Collins (lifeless)
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.