License in About dialog is difficult to read due to formatting problems
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
qBittorrent |
Fix Released
|
Low
|
Christophe Dumez |
Bug Description
About --> License has formatting problems. The italicized special exceptions section does not have spaces inserted between all words. More seriously, the GPL is extremely difficult to read because the original line breaks are preserved, but the width of the text box is smaller than the lines, producing frequent and seemingly random extraneous line breaks.
The attached patch (to src/about_imp.h, svn trunk revision 4327) fixes these bugs. It addresses the added line breaks by replacing (only) the semantically insignificant <br> tags with spaces. This causes the GPL text to automatically wrap to the width of the text box that contains it.
I have deliberately not done this to the sample text that the GPL suggests authors put at the top of source code files. I am not sure if I am making the right call here, but my reasoning is that the formatting, as it is, is conducive to copying and pasting into a source code file.
Changed in qbittorrent: | |
status: | Fix Committed → Fix Released |
This is fixed in SVN. Thanks a lot.