Percent complete reports 100% for 'Not Downloaded' files

Bug #650979 reported by John Supplee
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
qBittorrent
Fix Released
Low
Christophe Dumez

Bug Description

The percent complete field on the files tab for a tracker reports 100% for all not downloaded files regardless of their true percent complete. The problem would appear to be easily fixed by commenting out two conditions (see attached patch).

Revision history for this message
John Supplee (jrsupplee) wrote :
Revision history for this message
Christophe Dumez (hydr0g3n) wrote :

Hi, I believe this is the wanted behavior. Since these files are not meant to be downloaded, there is little point actually displaying their progress (at least I thought so). Those files are partly downloaded only because we have to download full pieces and pieces often overlap on two files. If we display the actual progress, users will start to wonder why ignored files are getting downloaded anyway.

What do you think?

Changed in qbittorrent:
assignee: nobody → Christophe Dumez (hydr0g3n)
status: New → Incomplete
Revision history for this message
John Supplee (jrsupplee) wrote :

Displaying the percent complete is a bit of a problem because of the reason that you suggested. However, it also isn't correct to mark the file as 100% downloaded. I think that either the percent complete should not be given for files that are downloaded, or the real percent complete.

What about little files that are smaller than the block side that might not be marked for download, but nonetheless are completely downloaded because they fall inside a desired block. How should their percent complete be displayed?

Revision history for this message
TBerk (bayareaberk-yahoo) wrote :

I would like to add my support for a blank field for files not marked OR an actual percentage of completness despite being marked or not.

"Hi, I believe this is the wanted behaviour. Since these files are not meant to be downloaded, there is little point actually displaying their progress (at least I thought so)..."

In fact it would seem the reverse is true; if they are of so little interest as to be unchecked it would seem, to me, that they should display as a 'zero completed' status.

With that said, I want to thank Christophe and everyone else working on this project.

TBerk

Revision history for this message
Christophe Dumez (hydr0g3n) wrote :

> In fact it would seem the reverse is true; if they are of so little interest as to be unchecked it would seem, to me, that they should display as a 'zero completed' status.

That would be lying to the user just to make him/her feel better :) As a user, I typically don't like software that doesn't report accurately what they are doing. Then again, I'm not necessarily an average user, some would even call me a "geek" :)

I'm still troubled by this and I need to give it some more thought in order to find an alternative that would not be lying. For example, omitting is not lying :) So maybe, simply not report any progress for "NOT downloaded" files?

Revision history for this message
TBerk (bayareaberk-yahoo) wrote :

I see your point, and mostly agree.

Still, BLANK would be better than 100%, in the case where the files are unchecked.

Revision history for this message
Christophe Dumez (hydr0g3n) wrote :

Ok, then. I'll make sure it is fixed for next bugfix version (in a while though because I'm travelling abroad).

Changed in qbittorrent:
importance: Undecided → Low
milestone: none → 2.9.3
status: Incomplete → Confirmed
Revision history for this message
Christophe Dumez (hydr0g3n) wrote :

This is fixed in the soon-to-be-released v2.9.3. Thanks for the bug report.
The approach chosen is not to display any progress bar for disabled files / folders.

Changed in qbittorrent:
status: Confirmed → Fix Committed
Changed in qbittorrent:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.