odd use of feature flags
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Undecided
|
Michael Nelson |
Bug Description
in distroseries.py, for the new differences stuff
def initialize(self):
"""Redirect to the derived series if the feature is not enabled."""
def in_scope(value):
return True
if feature_
return
This is buggy - it will match too many scopes, and its also way more code than is needed.
This is better:
def initialize(self):
"""Redirect to the derived series if the feature is not enabled."""
if features.
return
super(
Related branches
- Graham Binns (community): Approve (code)
-
Diff: 427 lines (+164/-85)9 files modifiedlib/canonical/launchpad/interfaces/__init__.py (+1/-0)
lib/lp/code/browser/tests/test_branchmergeproposal.py (+2/-62)
lib/lp/registry/browser/distroseries.py (+4/-8)
lib/lp/registry/browser/tests/test_distroseriesdifference_webservice.py (+61/-0)
lib/lp/registry/browser/tests/test_series_views.py (+25/-7)
lib/lp/registry/interfaces/distroseriesdifference.py (+16/-2)
lib/lp/registry/model/distroseriesdifference.py (+13/-6)
lib/lp/registry/tests/test_distroseriesdifference.py (+32/-0)
lib/lp/testing/factory.py (+10/-0)
Changed in soyuz: | |
status: | New → In Progress |
milestone: | none → 10.10 |
tags: |
added: qa-untestable removed: qa-needstesting |
Changed in soyuz: | |
status: | Fix Committed → Fix Released |
Fixed in db-stable r9813 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ db-stable/ revision/ 9813>.