default directory path in BookReader.js

Bug #641011 reported by Michael Howard
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Internet Archive BookReader
Fix Released
Medium
mangtronix

Bug Description

I pulled the source from git.

I ran the BookReaderDemo

I got 404 not found errors when looking for

http://localhost:8080/bookreader/images//transparent.png

Using BookReader cvs revision 1.2

line 78 says

    this.imagesBaseURL = '/bookreader/images/';

The demo uses CamelCase for the directory name ... BookReader

So, /bookreader does not match /BookReader on a case-sensitive file system.

I suggest that

1. Your code be changed to /BookReader (or change everything to /bookreader)

2. It looks to me like this can be overridden in BookReaderJSSimple.js
I think you should show this there in order to demonstrate that this is something people would have to change if they ran this on their own web site.

Separately ... *great* work on the Open Library BookReader

Michael

mangtronix (mang)
Changed in bookreader:
assignee: nobody → mangtronix (mang)
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
mangtronix (mang) wrote :

I changed the imagesBaseURL in the demo to be ../BookReader/images. It should now work on case-sensitive file systems and shows how to override it.

I also added a BookReaderDemo.css that shows how to override the BookReader CSS.

Changed in bookreader:
milestone: none → r28
status: Confirmed → Triaged
mangtronix (mang)
Changed in bookreader:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.