move geoip code to lp.services
Bug #636453 reported by
Curtis Hovey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Curtis Hovey | ||
Bug Description
This should be done so that bug fixes to geoip happen in the approved code locations.
Related branches
lp://staging/~sinzui/launchpad/dedup-preferred-launguages-0
- Aaron Bentley (community): Approve
-
Diff: 511 lines (+93/-82)18 files modifiedlib/canonical/launchpad/configure.zcml (+0/-2)
lib/canonical/launchpad/helpers.py (+20/-17)
lib/canonical/launchpad/interfaces/__init__.py (+0/-1)
lib/canonical/launchpad/zcml/configure.zcml (+0/-1)
lib/canonical/widgets/location.py (+2/-2)
lib/lp/registry/browser/distribution.py (+4/-4)
lib/lp/registry/browser/person.py (+1/-1)
lib/lp/services/apachelogparser/base.py (+1/-1)
lib/lp/services/configure.zcml (+3/-0)
lib/lp/services/geoip/__init__.py (+3/-0)
lib/lp/services/geoip/configure.zcml (+23/-23)
lib/lp/services/geoip/doc/geoip.txt (+5/-5)
lib/lp/services/geoip/helpers.py (+11/-6)
lib/lp/services/geoip/model.py (+2/-4)
lib/lp/services/geoip/tests/test_doc.py (+14/-10)
lib/lp/services/geoip/tests/test_request_country.py (+2/-2)
lib/lp/translations/browser/translations.py (+1/-1)
lib/lp/translations/doc/preferred-languages.txt (+1/-2)
lp://staging/~sinzui/launchpad/dedup-preferred-launguages-1
- Aaron Bentley (community): Approve
- Launchpad code reviewers: Pending (code) requested
-
Diff: 62 lines (+16/-5)3 files modifiedlib/canonical/launchpad/tests/test_helpers.py (+2/-2)
lib/lp/services/geoip/model.py (+2/-2)
lib/lp/translations/doc/preferred-languages.txt (+12/-1)
| Changed in launchpad-foundations: | |
| status: | Triaged → In Progress |
| Changed in launchpad-foundations: | |
| status: | In Progress → Fix Committed |
| tags: | added: qa-ok |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #1 |
| Changed in launchpad-foundations: | |
| milestone: | 10.09 → 10.10 |
| tags: |
added: qa-needstesting removed: qa-ok |
| tags: |
added: qa-ok removed: qa-needstesting |
| tags: |
added: qa-needstesting removed: qa-ok |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-foundations: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r11549 <http://