OQGRAPH is silently not compiled if boost is missing

Bug #635633 reported by Philip Stoev
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MariaDB
Fix Released
Undecided
Sergei Golubchik

Bug Description

OQGRAPH is silently not compiled if boost is missing -- configure mentions the fact in passing and proceeds to compile a binary. Instead, ./configure should have failed.

Silent non-compilation of engines and features has been a historic problem for MySQL -- the MTR test suite does not detect such omissions and simply skips the relevant tests, which requires extra scripts and work at build time to verify that the binary contains all desired features. Explicit ./configure failures are much easier to detect.

Tags: oqgraph

Related branches

Changed in maria:
milestone: none → 5.2
assignee: nobody → Sergei (sergii)
Revision history for this message
Sergei Golubchik (sergii) wrote : Re: [Bug 635633] [NEW] OQGRAPH is silently not compiled if boost is missing

Hi, Philip!

I suppose you want

  ./configure --with-plugin-oqgraph

to fail if oqgraph is not built, but plain

  ./configure

should not fail.

On Sep 11, Philip Stoev wrote:
>
> Public bug reported:
>
> OQGRAPH is silently not compiled if boost is missing -- configure
> mentions the fact in passing and proceeds to compile a binary. Instead,
> ./configure should have failed.
>
> Silent non-compilation of engines and features has been a historic
> problem for MySQL -- the MTR test suite does not detect such omissions
> and simply skips the relevant tests, which requires extra scripts and
> work at build time to verify that the binary contains all desired
> features. Explicit ./configure failures are much easier to detect.
>
> ** Affects: maria
> Importance: Undecided
> Assignee: Sergei (sergii)
> Status: New
>
>
> ** Tags: oqgraph
>
> ** Changed in: maria
> Milestone: None => 5.2
>
> ** Changed in: maria
> Assignee: (unassigned) => Sergei (sergii)
>
> --
> OQGRAPH is silently not compiled if boost is missing
> https://bugs.launchpad.net/bugs/635633
> You received this bug notification because you are a member of Maria-
> captains, which is the registrant for Maria.
>
> Status in Maria: New
>
> Bug description:
> OQGRAPH is silently not compiled if boost is missing -- configure mentions the fact in passing and proceeds to compile a binary. Instead, ./configure should have failed.
>
> Silent non-compilation of engines and features has been a historic problem for MySQL -- the MTR test suite does not detect such omissions and simply skips the relevant tests, which requires extra scripts and work at build time to verify that the binary contains all desired features. Explicit ./configure failures are much easier to detect.
>
>
>
Regards,
Sergei

Revision history for this message
Philip Stoev (pstoev-askmonty) wrote :

Yes exactly.

Changed in maria:
status: New → Fix Committed
Changed in maria:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.