Mixxx

Fix engineshoutcast metadata and PlayerInfo

Bug #630969 reported by Guy Martin on 2010-09-05

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Mixxx	Fix Released	Undecided	Unassigned	Mixxx 1.9.0

Bug Description

The attached patch fixes Player and PlayerInfo so that TrackInfo gets correctly updated after loading.
It also fixes engineshoutcast to make use of custom defined metadata and other stream informations that the user can configure in the shoutcast dialog. Those informations were never used before.

Revision history for this message

Guy Martin (gmsoft) wrote on 2010-09-05:

Fix PlayerInfo and Shoutcat metadata Edit (9.5 KiB, text/plain)

Revision history for this message

Albert Santoni (gamegod) wrote on 2010-09-06: Re: [Bug 630969] Re: Fix engineshoutcast metadata and PlayerInfo

Hi Guy,

Thanks for the patch! What branch is this against? There's already a
bunch of shoutcast fixes in another branch, and I'm not sure what's
included in there...

https://code.launchpad.net/~raffitea/mixxx/shoutcast_fixes

Maybe Tobias can handle this?

Thanks,
Albert

On Sun, Sep 5, 2010 at 9:44 AM, Guy Martin <email address hidden> wrote:
>
> ** Patch added: "Fix PlayerInfo and Shoutcat metadata"
> https://bugs.launchpad.net/bugs/630969/+attachment/1546780/+files/mixxx-shoutcat-metadata.difff
>
> --
> Fix engineshoutcast metadata and PlayerInfo
> https://bugs.launchpad.net/bugs/630969
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
>

Revision history for this message

RAFFI TEA (raffitea) wrote on 2010-09-06:

Hi Guy,

Thanks for all your work. I have already addressed this bug in my branch a couple of month ago. Streaming metadata works fine for MP3 but not for OGG which causes interruptions on song change. Maybe you are able to find a better solution but to be honest even Traktor has the problem :-) Therefore, static metadata should be used along with OGG streaming.

I would prefer to see any shoutcast related patch to in branch first. This avoids merging conflicts later on!

RAFFI TEA (raffitea) on 2010-09-06

Changed in mixxx:
status:	New → Fix Committed

Revision history for this message

Guy Martin (gmsoft) wrote on 2010-09-06:

Ah right, I got told about this branch but forgot about it.

I'll give it a try if I have a chance but wouldn't it be best to merge such fixes into trunk ?

Revision history for this message

RAFFI TEA (raffitea) wrote on 2010-09-06:

My merging proposal has been approved. I do not know when our next merging phase starts. I guess it will be shortly after the 1.8 release.

Revision history for this message

Guy Martin (gmsoft) wrote on 2010-09-06:

Ah ok.

This seems like a bug to me.
I'd like to see that integrated into the 1.8 release.

I'll try to discuss that on IRC or maybe I should subscribe to the mailing list :)

Revision history for this message

RJ Skerry-Ryan (rryan) wrote on 2010-09-07:

Hey Guy,

1.8 will not have shoutcast support enabled so it is sort of a moot point :). Shoutcast broadcasting is currently slated for Mixxx 1.9 and I just merged Raffi's work into the trunk, so this should be resolved in trunk now as well. Sorry for the confusion! It's taken too long to merge his work in since we're hacking away at 1.8.0.

Cheers,
RJ Ryan

RJ Skerry-Ryan (rryan) on 2010-10-05