default button in each step should grab default
Bug #625529 reported by
John Lenton
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Single Sign On Client |
Fix Released
|
High
|
Natalia Bidart | ||
| ubuntu-sso-client (Ubuntu) |
Fix Released
|
Medium
|
Natalia Bidart | ||
| Maverick |
Fix Released
|
Medium
|
Natalia Bidart | ||
Bug Description
hitting enter advances to the next step by hooking up the signals manaully. We should instead use grab_default, to give additional cues to the user.
Related branches
lp://staging/~nataliabidart/ubuntu-sso-client/default-buttons
- Rodrigo Moya (community): Approve
- Alejandro J. Cura (community): Approve
-
Diff: 140 lines (+70/-0)2 files modifiedubuntu_sso/gui.py (+22/-0)
ubuntu_sso/tests/test_gui.py (+48/-0)
| Changed in ubuntu-sso-client: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| assignee: | nobody → Naty Bidart (nataliabidart) |
| tags: | added: desktop+ u1-maverick |
| Changed in ubuntu-sso-client (Ubuntu): | |
| status: | New → Triaged |
| assignee: | nobody → Naty Bidart (nataliabidart) |
| milestone: | none → ubuntu-10.10 |
| importance: | Undecided → Medium |
Revision history for this message
| Alejandro J. Cura (alecu) wrote | #1 |
| Changed in ubuntu-sso-client: | |
| status: | Triaged → Fix Committed |
| Changed in ubuntu-sso-client (Ubuntu Maverick): | |
| status: | Triaged → Fix Released |
| Changed in ubuntu-sso-client: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Some more info to solve this issue:
The default buttons should have the gtk.CAN_DEFAULT flag set, using .set_flags or Glade:
http://
When the corresponding dialog "page" is shown, the button should grab the default with .grab_default:
http://