Launchpad itself

DistroArchSeries:+index timing out ~ 7% of the time

Bug #618395 reported by Robert Collins
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Julian Edwards
Launchpad itself 11.02

Bug Description

DistroArchSeries:+index is exceeding our timeout threshold ~7% of the time according to https://devpad.canonical.com/~stub/ppr/lpnet/latest-daily-timeout-candidates.html

Its a high volume page, so I'd expect this to be in our daily oops-by-volume reports.

OOPS-1846A1401

See original description

Related branches

lp://staging/~julian-edwards/launchpad/timeout-das-bug-618395
Robert Collins (community): Approve
Diff: 83 lines (+30/-19)
2 files modified
lib/lp/soyuz/browser/packagesearch.py (+2/-2)
lib/lp/soyuz/model/distroarchseries.py (+28/-17)
Curtis Hovey (sinzui)
affects: launchpad-registry → soyuz
Robert Collins (lifeless)
tags: added: pg83
Robert Collins (lifeless)
Changed in launchpad:
importance: High → Critical
Julian Edwards (julian-edwards)
description: updated
tags: removed: pg83
Julian Edwards (julian-edwards)
Changed in launchpad:
status: Triaged → In Progress
status: In Progress → Triaged
Revision history for this message
Julian Edwards (julian-edwards) wrote :

The batch navigator seems to be issuing the "count" query three times (each one taking 2.5 seconds), and one of them is coming from the view's "matches" property. The latter can just use the batch's total() method but it would be nice to work out WTF the batch navigator is doing.

Changed in launchpad:
assignee: nobody → Julian Edwards (julian-edwards)
Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 618395] Re: DistroArchSeries:+index timing out ~ 7% of the time

Also worth noting is that the case of a query for '' is not being
optimised out -
 count
-------
 54249
(1 row)

Time: 7986.742 ms

vs

 count
-------
 54249
(1 row)

Time: 2156.876 ms

if the ftq and ilike clauses are discarded for a query of '' - which
is reasonable as the fields are not NULLable.

If this isn't addressed at the same time we probably want a bug open
for it, because its a substantial efficiency win for the list-all
case.

Revision history for this message
Julian Edwards (julian-edwards) wrote :

The view is instantiating a non-cached batchnav ...

Changed in launchpad:
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r12265 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12265>.

Changed in launchpad:
milestone: none → 11.02
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Julian Edwards (julian-edwards)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.