name and email fields are switched by lp janitor in changelog mentions

Bug #618231 reported by Vish
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Won't Fix
Low
Unassigned

Bug Description

Lp janitor switches the name and email fields when there are dots in the uploader's name, in changelog entries.

This always happens to any upload I do irrespective of me using bzr or a debdiff for the upload:
https://launchpad.net/ubuntu/maverick/+source/humanity-icon-theme/+changelog [always use bzr for these]
https://launchpad.net/ubuntu/+source/system-config-printer/1.2.3+20100723-0ubuntu3 [debdiff]

It also happened for this uploader whose name has a dot too:
https://launchpad.net/ubuntu/+source/acm/5.0-27ubuntu2

To note is that the changelog entries are uploaded correctly, but only lp janitor seems to switch them in launchpad mentions everywhere [while closing bugs, and other changelog mentions in lp].
And there is no such problem when viewing the changelog either from synaptic[download changelog] or while viewing the changelogs in the system.

It just seems that lp janitor doesnt like uploaders with dots in their names. ;-)

Revision history for this message
William Grant (wgrant) wrote :

Interestingly, this seems to be deliberate:

def fix_maintainer(maintainer, field_name="Maintainer"):
    """Parses a Maintainer or Changed-By field and returns:

    (1) an RFC822 compatible version,
    (2) an RFC2047 compatible version,
    (3) the name
    (4) the email

    The name is forced to UTF-8 for both (1) and (3). If the name field
    contains '.' or ',', (1) and (2) are switched to 'email (name)' format.
    """

But there's no rationale given, and none is obvious to me.

Revision history for this message
Julian Edwards (julian-edwards) wrote :

Thanks for reporting this Vish. Can you explain the problems that this is causing for you?

Thanks.

Changed in soyuz:
status: New → Incomplete
Revision history for this message
Vish (vish) wrote :

As i mentioned earlier, this is not a major problem other than the entires standing out apart from others.
But why does it need to do that?
Sometimes i get questioned if i uploaded the changelog the wrong way! [not by the uploaders ofcourse]

What is wrong if my name has a dot? Is it breaking something? why is there a need for such names to be special cased? why treat it different?

Changed in soyuz:
status: Incomplete → New
Changed in soyuz:
status: New → Triaged
importance: Undecided → Low
tags: added: soyuz-upload
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

This behaviour is because of Debian policy 5.6.2 (http://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Maintainer):

"If the maintainer's name contains a full stop then the whole field will not work directly as an email address due to a misfeature in the syntax specified in RFC822; a program using this field as an address must check for this and correct the problem if necessary (for example by putting the name in round brackets and moving it to the end, and bringing the email address forward)."

Changed in soyuz:
status: Triaged → Won't Fix
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r11375 (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11375) by a commit, but not testable.

tags: added: qa-untestable
Revision history for this message
Vish (vish) wrote :

@Jelmer Vernooij , Thanks for pointing that out.. :)

Ursula Junque (ursinha)
Changed in soyuz:
milestone: none → 10.09
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.