KARL3

Send e-mail alerts turned on in Office Forums

Bug #616358 reported by JimPGlenn on 2010-08-11

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	KARL3	Fix Released	Medium	Chris Rossi	KARL3 m45

Bug Description

It looks like email alerts are turned on for comments in office forums
(see screenshot). There should not be an email alert option in office
forums.

Thanks,

Nat

Tags:

Revision history for this message

JimPGlenn (jpglenn09) wrote on 2010-08-11:

comments in forums.JPG Edit (103.4 KiB, image/jpeg)

reported via rt http://rt01.sixfeetup.com/Ticket/Display.html?id=81046

tags:

added: karl-support

Revision history for this message

Paul Everitt (paul-agendaless) wrote on 2010-08-11:

Looks like the adapter that decides when to show the "send alert?" field on a form has a misfire.

Changed in karl3:
assignee:	nobody → Chris Rossi (chris-archimedeanco)
importance:	Undecided → Medium
milestone:	none → m45

Revision history for this message

Chris Rossi (chris-archimedeanco) wrote on 2010-08-11:

AFAICT, the formish refactored add comment form does not consult the show send alert adapter. I'll rectify that.

Revision history for this message

Chris Rossi (chris-archimedeanco) wrote on 2010-08-11:

I have fixed this for the 'add comment' form. I have noticed, though, that many forms which show the sendalert field do not consult the show send alert adapter. The 'add blog entry' form is an example. These forms always show the send alert field no matter what. Since this doesn't conflict with current policy for any of our partners, this doesn't surface as a bug. If some partner wanted to change the policy for showing the sendalert field for some of these forms, then we would need to update the code for those forms to check the policy--not merely change the policy. If that makes sense. I'm not sure if updating those forms now to respect the policy is really a priority--certainly it would be a low priority. But thought I would throw that out there. If all forms should be checking the show sendalert adapter, then let's open a new ticket for that and give it a fairly low priority.