Timesheet validation Sign in/Sign out count check

Bug #616258 reported by Vincent Renaville@camptocamp
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Undecided
Ravindra Mekhiya(OpenERP)

Bug Description

Hello,

I have a problem and a patch for a use case concerning timesheet :

- an employee make his timesheet for the week
- He forget to make his last Signout on Friday
- He confirm the timesheet
- The next week, he start a new timesheet, but he cannot made a new signin because signin must follow a signout
- He decide to change the timesheet from last week, but he can't because in his company only de HR manager can unconfirm timesheet

So i have made a patch on button_confirm, that check that count signin an signout and raise a error if he found a difference when you confirm your timesheet

Thanks for your Help

Vincent

Revision history for this message
Vincent Renaville@camptocamp (vrenaville-c2c) wrote :
Changed in openobject-addons:
assignee: nobody → RME(OpenERP) (rme-openerp)
Changed in openobject-addons:
status: New → Confirmed
Revision history for this message
Ravindra Mekhiya(OpenERP) (rme-openerp) wrote :

Hello Vincent,

Should not the check be made before the allowing workflow signal?
I meant, your method should be called just after the for loop starts.

Thanks.

Revision history for this message
Vincent Renaville@camptocamp (vrenaville-c2c) wrote :

Hello,

I agree with you
Could you please correct it directly ?

Thanks for your precious help,

Vincent

Revision history for this message
Ravindra Mekhiya(OpenERP) (rme-openerp) wrote :

Hello Vincent,

We will do it directly,

Thanks for your concern.

Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

Hi Vincent,

Thanks for pointing,it has been fixed by revision 2809 <email address hidden> with a suitable patch authored to RME and Vincent.

Changed in openobject-addons:
milestone: none → 5.0.13
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.