play framework

downloading big files is broken

Bug #612836 reported by bran
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
play framework
Fix Committed
High
Nicolas Leroux
play framework 1.1

Bug Description

with the latest nightly in the 1.1 branch, downloading big files is broken.

windows 7, jdk 1.6.20, play! 1.1-unstable-r982

Serving files in the public folder of applications is unreliable. Any files bigger than 80+K are truncated. Start to display this behavior when file sizes approach 80K.

Nicolas Leroux (nicolas-lunatech)
Changed in play:
assignee: nobody → Nicolas Leroux (nicolas-lunatech)
Revision history for this message
dirk (australiandeveloper) wrote :

I'm seeing the same behaviour on a mac with firefox and safari.

Nicolas Leroux (nicolas-lunatech)
Changed in play:
importance: Undecided → High
status: New → In Progress
Nicolas Leroux (nicolas-lunatech)
Changed in play:
milestone: none → 1.1
status: In Progress → Fix Committed
Revision history for this message
dirk (australiandeveloper) wrote :

Works for me now, thanks for the quick fix!

Revision history for this message
dirk (australiandeveloper) wrote :

Hmm actually after doing some more testing it seems it didn't actually work.
Still having the issue with both firefox and safari on my mac, at revision 1.1-unstable-r988

Revision history for this message
Nicolas Leroux (nicolas-lunatech) wrote :

Hmm I cannot reproduce it anymore... Do you do anything special?

Revision history for this message
bran (bing-ran) wrote :

I just did a merge from the master and "ant clean" and "ant". The problem was still there. For a file of 85K it worked sometimes and failed otherwise.

Nicolas Leroux (nicolas-lunatech)
Changed in play:
status: Fix Committed → Confirmed
Revision history for this message
dirk (australiandeveloper) wrote :

I'm also still seeing the problem on mac firefox/safari

I had a look at the diff, and if I understand right, the piece of code that you changed (line 332) is only called if a plugin is rendering a static file. Do you need to make the same change for static files that are rendered by normal Controllers? If so, you'd need to change line 671:

http://bazaar.launchpad.net/~play-developers/play/1.1-unstable/annotate/988/framework/src/play/server/PlayHandler.java#L670

Revision history for this message
Nicolas Leroux (nicolas-lunatech) wrote :

Yes you are quite right, that is the mistake :) Thank you so much!!

Revision history for this message
Nicolas Leroux (nicolas-lunatech) wrote :

Can you check again? Thanks

Revision history for this message
dirk (australiandeveloper) wrote :

Yes it works for me now :)

Revision history for this message
bran (bing-ran) wrote :

looks good here too. Thanks a lot!

Revision history for this message
Nicolas Leroux (nicolas-lunatech) wrote :

No thanks to both of you for the bug report!

Changed in play:
status: Confirmed → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.