test consumer should allow user to define teams query
Bug #611830 reported by
Stuart Metcalfe
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical SSO provider |
Fix Released
|
Medium
|
Stuart Metcalfe | ||
Bug Description
the test consumer has the teams hard-coded: myteam,
we should provide a text field to allow these to be changed
Related branches
lp://staging/~canonical-isd-hackers/canonical-identity-provider/bug-611830-test-consumer-set-teams
- Łukasz Czyżykowski (community): Approve
-
Diff: 59 lines (+20/-5)2 files modifiedidentityprovider/templates/consumer/index.html (+13/-2)
identityprovider/views/consumer.py (+7/-3)
lp://staging/~canonical-isd-hackers/canonical-identity-provider/bug-611830-test-fixes
- Canonical ISD hackers: Pending requested
-
Diff: 23 lines (+7/-2)1 file modifiedidentityprovider/tests/test_views_consumer.py (+7/-2)
Revision history for this message
| Łukasz Czyżykowski (lukasz-czyzykowski) wrote | #1 |
| Changed in canonical-identity-provider: | |
| assignee: | nobody → Stuart Metcalfe (stuartmetcalfe) |
| status: | Confirmed → In Progress |
| milestone: | none → 2-implementation |
| Changed in canonical-identity-provider: | |
| status: | In Progress → Fix Committed |
| milestone: | 2-implementation → 3-internal-qa |
Revision history for this message
| Łukasz Czyżykowski (lukasz-czyzykowski) wrote | #2 |
Revision history for this message
| Dave Morley (davmor2) wrote | #3 |
| Changed in canonical-identity-provider: | |
| milestone: | 3-internal-qa → 4-staging |
Revision history for this message
| Julien Funk (jaboing) wrote | #4 |
| Changed in canonical-identity-provider: | |
| milestone: | 4-staging → 5-production |
Revision history for this message
| Dave Morley (davmor2) wrote | #5 |
| Changed in canonical-identity-provider: | |
| milestone: | 5-production → 2.10.0 |
| Changed in canonical-identity-provider: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Currently consumer uses 'teams' query argument to decide if it needs to add that hard coded list of teams, instead that argument should be a comma separated list itself.