text incorrectly marked for translation in account module

Bug #609865 reported by Albert Cervera i Areny - http://www.NaN-tic.com
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Undecided
Anup(SerpentCS)

Bug Description

There's a string that is not properly marked for translation in the account module.

The attached patch fixes it for v5.0.

Revision history for this message
Albert Cervera i Areny - http://www.NaN-tic.com (albert-nan) wrote :
Changed in openobject-addons:
status: New → Confirmed
Revision history for this message
Anup(SerpentCS) (anup-serpent) wrote :

Hello Albert,

    Thanks a lot for pointing towards the issue. I agree with it and I have found a generic solution for such translations problems in account module. I have attached a refined patch. Would you please check it and notify us?

Thanks.

Changed in openobject-addons:
assignee: nobody → Anup (Open ERP) (ach-openerp)
milestone: none → 5.0.13
status: Confirmed → In Progress
Changed in openobject-addons:
milestone: 5.0.13 → none
Revision history for this message
Albert Cervera i Areny - http://www.NaN-tic.com (albert-nan) wrote :

Hi Anup,
I think you didn't see what I meant. Look carefully at the patch I provided. I moved the closing parenthesis from the end of the line to the end of the string to be translated. That's the only issue.

Changed in openobject-addons:
status: In Progress → New
Revision history for this message
Anup(SerpentCS) (anup-serpent) wrote :

Hello Albert,

       I have done the same in case of your problem but there were few more translation issues because of that the translations wont be shown in the client so this changes are mandatory. I agree with your patch and what you have suggested but mine is just a refined version of yours patch. And this will be fixed soon.

Thanks.

Changed in openobject-addons:
status: New → In Progress
Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

@Albert:
Thanks for the bug report and the patch!

@Anup:
Thanks for taking care of fixing the translations in the .po files too!
However Albert is right too: in his patch the only important thing is to move the closing parenthesis at the end of the string to translate, and you did not do that in your patch.
So you must apply Albert's patch too in addition to yours to move the closing parenthesis right after "... all currencies." , otherwise the translation will not work as _( ) will be called *after* the string formatting!
Thank you for taking care of this issue!

Revision history for this message
Anup(SerpentCS) (anup-serpent) wrote :

Hello Olivier,

   Yes as i said earlier I agree with Albert's patch in his case I have done the same as he suggested. I have also taken care of the other translations. Here is the updated patch for that.

Thanks.

Revision history for this message
Anup(SerpentCS) (anup-serpent) wrote :

Hello Albert,

   It has been fixed by revision 2848 <email address hidden>

Thanks a lot for pointing out the issue.

Changed in openobject-addons:
milestone: none → 5.0.15
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.