Importer incorrectly detects untagged pushes

Bug #608156 reported by James Westby
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Distributed Development
Fix Released
High
Unassigned

Bug Description

The importer currently considers a revision an untagged push if it brings no
changes vs. an import of the upload it is considering.

This is incorrect when the upload contains all changes present in the branch
but adds further changes.

The correct check is to compare the current tip to the test import of the new
upload, either via iter_changes (only considering content changes and
adds/deletes/renames/executability etc.), or by merging the test import in
the current tip and checking for a resulting empty diff.

Further, if the above detects that there are changes, it should check for
whether the merge of the current tip in to the test import brings in any
changes. If it does it should propose them for merge, and squash them
out of the history. If it doesn't we could preserve them in the history and
not propose a merge, as the content is all already included.

James Westby (james-w)
Changed in udd:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.