Hook before event deletions missing
Bug #604747 reported by
Siegfried Gevatter
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Zeitgeist Framework |
Fix Released
|
Medium
|
Seif Lotfy | ||
Bug Description
Now that there is a hook called after event deletions (with which I only agree because of performance reasons for the FTS extension, as it is basically duplicating the D-Bus interface), there should also be a hook called before events are deleted which can stop that from happening.
Related branches
lp://staging/~zeitgeist/zeitgeist/hooks
- Siegfried Gevatter: Approve
- Seif Lotfy: Approve
-
Diff: 285 lines (+119/-31)5 files modified_zeitgeist/engine/extension.py (+61/-18)
_zeitgeist/engine/extensions/blacklist.py (+1/-1)
_zeitgeist/engine/extensions/datasource_registry.py (+1/-1)
_zeitgeist/engine/main.py (+6/-2)
test/engine-extension-test.py (+50/-9)
| Changed in zeitgeist: | |
| milestone: | none → 0.4.1 |
Revision history for this message
| Markus Korn (thekorn) wrote | #1 |
Revision history for this message
| Siegfried Gevatter (rainct) wrote Re: [Bug 604747] Re: Hook before event deletions missing | #2 |
Revision history for this message
| Mikkel Kamstrup Erlandsen (kamstrup) wrote | #3 |
Revision history for this message
| Siegfried Gevatter (rainct) wrote | #4 |
| Changed in zeitgeist: | |
| assignee: | nobody → Seif Lotfy (seif) |
| importance: | Undecided → Medium |
| status: | New → Triaged |
| Changed in zeitgeist: | |
| status: | Triaged → Fix Released |
| Changed in zeitgeist: | |
| milestone: | 0.4.1 → 0.5.0 |
To post a comment you must log in.
Maybe we should take the chance and rethink the neaming scheme of hooks, so they better describe what they are doing, I propose sth. like:
pre_insert_event
post_delete_event
pre_delete_event
[...]
(I think we can also drop the _hook suffix)