Launchpad itself

Excessive queries on the merge proposal page

Bug #595377 reported by Tim Penhey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Tim Penhey
Launchpad itself 10.07

Bug Description

OOPS-1625G1331 is an example.

For every group of new revisions being shown, the bzr_identity is being rendered, which hits the db twice.

Related branches

lp://staging/~thumper/launchpad/bmp-index-faster
Stuart Bishop (community): Approve
Diff: 428 lines (+191/-118)
3 files modified
lib/lp/code/browser/branch.py (+2/-108)
lib/lp/code/browser/branchmergeproposal.py (+6/-10)
lib/lp/code/browser/decorations.py (+183/-0)
Tim Penhey (thumper)
Changed in launchpad-code:
status: In Progress → Fix Committed
Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit

Fixed in stable r11030 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11030>.

tags: added: qa-needstesting
Revision history for this message
Tim Penhey (thumper) wrote :

Confirmed that the fix that the branch adds does work, but the page occasionally still times out due to the massive amount of formatting it is doing (https://code.edge.launchpad.net/~openerp-commiter/openobject-addons/trunk-extra-addons/+merge/6722/+index).

tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.