GhostWidget content appears in pages
Bug #594419 reported by
Curtis Hovey
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Unassigned |
Bug Description
The GhostWidget is intended to suppress the the field from being rendered in the page. You can see the license_info hint text in the +new project page. While the <input< was not rendered, pther part are. The probelm is that the widget attribute can and are set after the widget is created. So while the hint is an empty string in the class definition, it is not at the time of rendering. The page contains table rows with empty blocks elements that render as extra white space in the page.
* The correct fix is to use the invisible attribute to indicate it should not be seen
* And update the launchpad-
Related branches
lp://staging/~sinzui/launchpad/bug-tracker-widget-1
- Graham Binns (community): Approve (code)
-
Diff: 107 lines (+54/-6)3 files modifiedlib/canonical/launchpad/templates/launchpad-form.pt (+6/-3)
lib/canonical/widgets/product.py (+3/-1)
lib/lp/registry/doc/product-widgets.txt (+45/-2)
tags: | added: qa-ok |
Changed in launchpad-foundations: | |
status: | In Progress → Fix Committed |
Changed in launchpad-foundations: | |
status: | Fix Committed → Fix Released |
Changed in launchpad: | |
assignee: | Curtis Hovey (sinzui) → nobody |
To post a comment you must log in.
Fixed in stable r11013 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 11013>.