bzr should not show stack trace on bad filename
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Confirmed
|
Medium
|
Unassigned |
Bug Description
while trying at this bug comment https:/
[tmp]% cat bugtest.sh
#!/bin/sh
rm -rf bugtest
mkdir bugtest
cd bugtest/
bzr init
touch `printf "\x83"`
bzr add
bzr status
[tmp]% ./bugtest.sh
Created a standalone tree (format: 2a)
adding \x83
bzr: ERROR: bzrlib.
Traceback (most recent call last):
File "/storage/
return the_callable(*args, **kwargs)
File "/storage/
ret = run(*run_argv)
File "/storage/
return self.run(
File "/storage/
return self._operation
File "/storage/
self.cleanups, self.func, *args, **kwargs)
File "/storage/
result = func(*args, **kwargs)
File "/storage/
no_recurse, action=action, save=not dry_run)
File "/storage/
return unbound(self, *args, **kwargs)
File "/storage/
_add_one(self, inv, parent_ie, directory, kind, action)
File "/storage/
file_
File "/storage/
return make_entry(kind, name, parent_id, file_id)
File "/storage/
return factory(file_id, name, parent_id)
File "/storage/
super(
File "/storage/
raise errors.
InvalidEntryName: Invalid entry name: \x83
You can report this problem to Bazaar's developers by running
apport-bug /var/crash/
if a bug-reporting window does not automatically appear.
unknown:
\x83
[tmp]%
Changed in bzr: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
tags: | added: unicode |
tags: | added: check-for-breezy |
A clearer error would be better, however its worrying that the bad
data got that far down the stack. I'd fix this one by figuring out
where the bad data entered, and correcting that code path.