Reads first 2 bytes more than once
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar Git Plugin |
Fix Released
|
Low
|
Jelmer Vernooij | ||
Dulwich |
Fix Released
|
Low
|
Jelmer Vernooij | ||
Launchpad itself |
Fix Released
|
Medium
|
Jelmer Vernooij |
Bug Description
I got the following crash while trying to branch from the public git mirror of the Scipy project
$ bzr branch http://
bzr: ERROR: exceptions.
Traceback (most recent call last):
File "/Users/
return the_callable(*args, **kwargs)
File "/Users/
ret = run(*run_argv)
File "/Users/
return self.run(
File "/Users/
return self._operation
File "/Users/
self.cleanups, self.func, *args, **kwargs)
File "/Users/
result = func(*args, **kwargs)
File "/Users/
revision_id = br_from.
File "/Users/
result = unbound(self, *args, **kwargs)
File "/Users/
return self.lookup_
File "/Users/
self.mapping)
File "/Users/
commit = self._git[
File "/Library/
return self.object_
File "/Library/
type_num, uncomp = self.get_raw(sha)
File "/Library/
return ret.type_num, ret.as_raw_string()
File "/Library/
return "".join(
File "/Library/
self.
File "/Library/
self.
File "/Library/
if self._is_
File "/Library/
b0, b1 = map(ord, magic)
ValueError: need more than 0 values to unpack
bzr 2.2.0dev1 on python 2.6.5 (Darwin-
arguments: ['/Users/
encoding: 'UTF-8', fsenc: 'utf-8', lang: 'en_US.UTF-8'
plugins:
automirror /Users/
bash_completion /Users/
bzrtools /Users/
colo /Users/
explorer /Users/
fastimport /Users/
git /Users/
hg /Users/
latex_
launchpad /Users/
netrc_
news_merge /Users/
qbzr /Users/
rst2html /Users/
$ python -c "import dulwich; print dulwich.
(0, 6, 0)
$ python --version
Python 2.6.5
Related branches
- Tim Penhey (community): Approve
- Launchpad code reviewers: Pending (code) requested
-
Diff: 24 lines (+4/-4)1 file modifiedutilities/sourcedeps.conf (+4/-4)
summary: |
- ValueError rather than ObjectFormatException on empty file + Reads first 2 bytes more than once |
Changed in bzr-git: | |
status: | New → Triaged |
importance: | Undecided → Low |
Changed in launchpad-code: | |
status: | New → Triaged |
importance: | Undecided → Medium |
Changed in dulwich: | |
milestone: | none → 0.6.1 |
assignee: | nobody → Jelmer Vernooij (jelmer) |
Changed in bzr-git: | |
status: | Triaged → Fix Committed |
Changed in dulwich: | |
status: | Triaged → Fix Committed |
Changed in dulwich: | |
status: | Fix Committed → Fix Released |
Changed in bzr-git: | |
milestone: | none → 0.5.2 |
Changed in bzr-git: | |
status: | Fix Committed → Fix Released |
Changed in bzr-git: | |
assignee: | nobody → Jelmer Vernooij (jelmer) |
Changed in launchpad-code: | |
assignee: | nobody → Jelmer Vernooij (jelmer) |
status: | Triaged → Fix Committed |
Changed in launchpad-code: | |
milestone: | none → 10.09 |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad-code: | |
status: | Fix Committed → Fix Released |
Dulwich should raise a better exception if it encounters an empty ShaFile.