Launchpad itself

Need fmt:link for SourcePackageRecipeBuild

Bug #587110 reported by William Grant
26
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Unassigned
Launchpad itself 10.07

Bug Description

SourcePackageRecipeBuilds used to use the fmt:link provided by the IBuildBase formatter. However, that formatter is now for IPackageBuild instead -- and SPRB is not an IPackageBuild. This means that /builders (among other pages) will crash when a recipe build is in progress.

SPRB needs to either become an IPackageBuild, or get an fmt:link some other way.

Tim Penhey (thumper)
tags: added: recipe ui
Changed in launchpad-code:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
William Grant (wgrant) wrote :

This must be fixed on production before we can even start doing recipe builds on edge.

Revision history for this message
Michael Nelson (michael.nelson) wrote :

Eventually (when the SPRecipeBuilds are updated to the new database tables) it will be an IPackageBuild, but I don't think it should be one until then.

I assume we'll be able to simply provide a second adapter for IBuildBase in the intermediate time (in lib/canonical/launchpad/webapp/configure.zcml):

{{{
    <adapter
        for="lp.buildmaster.interfaces.buildbase.IBuildBase"
        provides="zope.traversing.interfaces.IPathAdapter"
        factory="canonical.launchpad.webapp.tales.BuildBaseFormatterAPI"
        name="fmt"
        />
}}}

I'll check this today.

Revision history for this message
Michael Nelson (michael.nelson) wrote :

Actually, I'm not seeing any problems locally viewing the buildfarm with a recipe build on the builder:
https://launchpad.dev/builders

This is running the branch that fixes bug 587113.

Revision history for this message
Michael Nelson (michael.nelson) wrote :

I think this is invalid, as there is already a SourcePackageRecipeBuildFormatterAPI which is used for SPRBuilds (which is what generates the link in the above screenshot).

Changed in launchpad-code:
status: Triaged → Invalid
Revision history for this message
Michael Nelson (michael.nelson) wrote :

The reason it's there is because Curtis added it to get us out of testfix last weekend :)

landed with r10951.

Changed in launchpad-code:
status: Invalid → Fix Committed
assignee: nobody → Michael Nelson (michael.nelson)
milestone: none → 10.06
assignee: Michael Nelson (michael.nelson) → Curtis Hovey (sinzui)
Curtis Hovey (sinzui)
tags: added: qa-ok
Curtis Hovey (sinzui)
Changed in launchpad-code:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
Changed in launchpad:
assignee: Curtis Hovey (sinzui) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.