lp-propose refuses to run when 'no reviewer is set'
Bug #583772 reported by
Robert Collins
This bug affects 3 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Bazaar |
Fix Released
|
Medium
|
Jelmer Vernooij | ||
Bug Description
It gets this by examining the branch for a 'target reviewer', which apparently lp:hydrazine doesn't have. However, launchpad permits a manual merge to be proposed, and that gets the branch owner (appropriately in this case) as a reviewer, so I'm not sure whats going on. I think we can probably just remove the check, and set self.reviews to None, which I think will use the default logic launchpad does [need to check the lp code first].
Related branches
lp://staging/~jelmer/bzr/lp-propose-default-reviewer
- John A Meinel: Approve
-
Diff: 29 lines (+5/-4)2 files modifiedbzrlib/plugins/launchpad/lp_propose.py (+1/-4)
doc/en/release-notes/bzr-2.4.txt (+4/-0)
| Changed in bzr: | |
| importance: | Wishlist → Medium |
| tags: | added: lp-propose |
| Changed in bzr: | |
| assignee: | nobody → Jelmer Vernooij (jelmer) |
| tags: | added: udd |
| Changed in bzr: | |
| status: | Confirmed → Fix Released |
| milestone: | none → 2.4b1 |
Revision history for this message
| Ted Gould (ted) wrote Re: [Bug 583772] Re: lp-propose refuses to run when 'no reviewer is set' | #1 |
To post a comment you must log in.
Thanks Jelmer!