Location marker doesn't update in Planning mode

Bug #579453 reported by Kieran Fleming
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenSatNav
Fix Released
Medium
droidguy

Bug Description

Obvious bug - SatNavActivity line 220 is the culprit

Revision history for this message
droidguy (stan-berka) wrote :

Yes, fix, straightforward, was in line 220. Patch file attached. Tested in emulator.

Revision history for this message
chris_debian (cjhandrew) wrote :

droidguy wrote:
> Yes, fix, straightforward, was in line 220. Patch file attached. Tested in emulator.

Nice one, thank you!

Chris.

Revision history for this message
chris_debian (cjhandrew) wrote :

chris_debian wrote:
> droidguy wrote:
> > Yes, fix, straightforward, was in line 220. Patch file attached. Tested in emulator.
>
> Nice one, thank you!
>
> Chris.

I should be travelling tomorrow, so can test. Will the patch be committed for the overnight build?

Chris

Revision history for this message
droidguy (stan-berka) wrote :

Actually, my simplistic fix from yesterday would always center the map around the current location. Even in planning mode. That wouldn't good. The attached OpenSatNav2.patch will update the location marker but center only in navigation mode.
droidguy

Revision history for this message
droidguy (stan-berka) wrote :

Chris,
I can commit it, but I don't have the password to update the repository. I tried the user/password I use to login to the OpenSatNav portland/website, but it doesn't like it.
droidguy

Revision history for this message
Guillaume Rosaire (zerog) wrote :

Patch applied in rev 111

It will be in next overnight build

Revision history for this message
chris_debian (cjhandrew) wrote :

ZeroG wrote:
> Patch applied in rev 111
>
> It will be in next overnight build

Good work! I'll download tomorrow. Be good to kill-off a 0.9 issue.

Thanks,

Chris.

Revision history for this message
chris_debian (cjhandrew) wrote :

Looks good in APK 112. Shall we close this, or would people like to test further?

Good work!

Chris.

Revision history for this message
Guillaume Rosaire (zerog) wrote :

The fix was rather trivial, I guess we can close this one.

Revision history for this message
chris_debian (cjhandrew) wrote :

ZeroG wrote:
> The fix was rather trivial, I guess we can close this one.

Thanks, guys. The fix may have been trivial, but it makes OSN. A more polished application and shouldn't be played-down.

Good work.

Chris.

Revision history for this message
droidguy (stan-berka) wrote :

Thanks, Chris. I agree, it was a trivial fix. Still I'm proud to do a first actual contribution to OSN. :-)
droidguy

Revision history for this message
chris_debian (cjhandrew) wrote :

droidguy wrote:
> Thanks, Chris. I agree, it was a trivial fix. Still I'm proud to do a first actual contribution to OSN. :-)
> droidguy

Nice one!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.