OpenStreetMapView has a black border when dragging

Bug #579439 reported by Will Uther
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenSatNav
Fix Released
Medium
Unassigned

Bug Description

Currently, when dragging an OpenStreetMapView, if you reach a tile that wasn't in the original display then it shows up as a black
square. The attached patch fixes this so that you should be able to drag freely and not encounter the edge cases. This also fixes one
potential issue that would have shown up when looking at issue #62, but I haven't done a thorough check to see if there are
any others.

Oh, and I significantly simplified the LRU in-memory tile cache. Someone had re-implemented standard java functionality so I switched back to the
standard implementation.

Revision history for this message
Will Uther (willu-mailinglists) wrote :

Kieran (Kizza?) noted that the above patch makes his G1 run too slowly. Attached is an additional patch (i.e. it applies on top of the previous one) that makes sure only map tiles that are going to be displayed will be loaded. This should return things to their previous speed if you're not dragging.

When dragging with this patch you'll see a bunch of the 'loading...' tiles, and they should be replaced with map tiles as those tiles load.

On my Hero I think I prefer the behaviour without this patch. I wonder if there is an intermediate behaviour - e.g. load when you're just off the screen, but not when you're two tiles off the screen (which is still reachable on a long drag, but much rarer).

Revision history for this message
Kieran Fleming (kieran-fleming) wrote :

Works much better, committed in rev 82.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.