Possible Concurrency issue.

Bug #579432 reported by Will Uther
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenSatNav
Fix Released
Medium
Kieran Fleming

Bug Description

I was looking at the source, and it seems there are some cases where java collections are accessed from two different threads. You need to used synchronized collections for this. Attached is a patch to fix this.

I haven't checked all the code for similar bugs, so there may be more cases where this would be useful.

Revision history for this message
chris_debian (cjhandrew) wrote :

Willu,

Thank you for submitting this patch. Sounds logical, but I'm going to pass it to Kizza, as he's our lead coder.

We really appreciate your help.

Chris.

Revision history for this message
chris_debian (cjhandrew) wrote :

Willu,

I should have said, most of the OSN development is done by a handful of people. Looking at the quality of the comments that you've made recently, we (the OSN Team) would welcome any comments you have regarding open issues, specifically release 0.9 at the moment:

http://www.opensatnav.org/versions/show/2

If you haven't done so already, you may want to have a look here:

http://www.opensatnav.org/wiki/osn/Talk_to_us_and_stay_in-touch

Apologies for posting here, but it seemed appropriate, plus I can't use gmail at work.

Cheers,

Chris.

Revision history for this message
Kieran Fleming (kieran-fleming) wrote :

Yep, looks good to me. Committed as revision 67.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.