OpenSatNav

No notification when services are unavailable

Bug #579370 reported by Kieran Fleming
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenSatNav
Fix Released
Medium
chris_debian
OpenSatNav 0.9

Bug Description

If there are no location services the program should tell the user about the problem, then ask if hey would like to open the location settings page to enable them
If there is no network connection we need to notify the user
If 'use wireless networks' is enabled but GPS isn't notify the user why the accuracy is bad.

Revision history for this message
chris_debian (cjhandrew) wrote :

If location services are not enabled, the user sees the following:

"No location services are enabled. Do you want to change this setting now?"

The user needs to make a choice and then press the back button.

The two options are currently 'OK' or 'Close'.

Can these be changed to 'Yes' or 'No'; this would answer the question "Do you want to change this setting now?".

Thanks,

Chris.

Revision history for this message
Guillaume Rosaire (zerog) wrote :

In the code, we have :

   builder.setMessage(R.string.location_services_disabled)
     .setCancelable(false).setPositiveButton(
      *android.R.string.yes*,
      new DialogInterface.OnClickListener() {
       //
      }).setNegativeButton(*android.R.string.no*,
      new DialogInterface.OnClickListener() {
       //
      });

Seems that android has a bug on the standard yes and no values, see below :
http://code.google.com/p/android/issues/detail?id=3713&q=android.R.string.yes&colspec=ID%20Type%20Status%20Owner%20Summary%20Stars

I'll temporarily add yes and no values in the translations files (OSN strings.xml), and we will revert to the standard android.R values once it's fixed upstream.

Revision history for this message
chris_debian (cjhandrew) wrote :

ZeroG wrote:
> In the code, we have :
>
> builder.setMessage(R.string.location_services_disabled)
> .setCancelable(false).setPositiveButton(
> *android.R.string.yes*,
> new DialogInterface.OnClickListener() {
> //
> }).setNegativeButton(*android.R.string.no*,
> new DialogInterface.OnClickListener() {
> //
> });
>
> Seems that android has a bug on the standard yes and no values, see below :
> http://code.google.com/p/android/issues/detail?id=3713&q=android.R.string.yes&colspec=ID%20Type%20Status%20Owner%20Summary%20Stars
>
> I'll temporarily add yes and no values in the translations files (OSN strings.xml), and we will revert to the standard android.R values once it's fixed upstream.

Good bit of research, thank you.

Chris.

Revision history for this message
Guillaume Rosaire (zerog) wrote :

Yes/No fixed in rev r113

Please test and close this bug if that is ok for you

Revision history for this message
chris_debian (cjhandrew) wrote :

ZeroG wrote:
> Yes/No fixed in rev r113
>
> Please test and close this bug if that is ok for you

Will download tomorrow morning.

Thanks,

Chris.

Revision history for this message
chris_debian (cjhandrew) wrote :

chris_debian wrote:
> ZeroG wrote:
> > Yes/No fixed in rev r113
> >
> > Please test and close this bug if that is ok for you
>
> Will download tomorrow morning.
>
> Thanks,
>
> Chris.

This appears to be fixed. Thank you, ZeroG.

Chris.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.