BugWatchUpdater.updateBugWatch() shouldn't take can_foo parameters

Bug #578714 reported by Graham Binns
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Graham Binns

Bug Description

At the moment BugWatchUpdater.updateBugWatch() takes parameters for can_import_comments, can_push_comments and can_back link. However, these are already defined as attributes of the class that instantiates BugWatchUpdater, RemoteBugUpdater, and a copy of the instantiating object is passed to the BugWatchUpdater as it's created, so there's really no need for these parameters to be passed.

The parameters should be removed and tests should be updated to use a RemoteBugUpdater object as the parent for new BugWatchUpdaters. (Note, I would do this in my current branch, but it's already too large).

Related branches

Graham Binns (gmb)
Changed in malone:
status: Triaged → In Progress
assignee: nobody → Graham Binns (gmb)
tags: added: bugjam2010
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit
tags: added: qa-needstesting
Changed in malone:
status: In Progress → Fix Committed
Graham Binns (gmb)
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in launchpad:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
Changed in launchpad:
milestone: none → 11.01
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.