when stopped, automount orphans some mounts

I forgot to mention that this is with autofs5 in Lucid Lynx, package version version 5.0.4-3.1ubuntu5.

Thanks Ill take a look at this for maverick.

chuck

This bug needs to be fixed in Oneiric, and a full SRU justification added to the bug description before the upload made to maverick-proposed can go into maverick-updates. In particular I'm interested in the regression potential involved with removing this patch. I'm going to hold off accepting it until the regression potential is documented.

Server team ping?

This is believed to be resolved in Oneiric (5.0.6), and I am attempting to confirm with upstream the commit which did this. Once I have clariffication, I will update the status as suitable.

Thanks.

This is fixed in Oneiric via autofs5 5.0.6 via:
From 52b4b907f4b41b09bde71da43b0325f4659d7e37 Mon Sep 17 00:00:00 2001
From: Ian Kent <email address hidden>
Date: Mon, 4 Apr 2011 15:42:01 +0800
Subject: [PATCH 1/1] autofs-5.0.5 - fix stale map read

A previous patch to fix direct maps not updating on re-read has
a side effect of causing maps to always be re-read on lookup.
This is because, following the application of the previous patch,
the map stale status is no longer being updated on a successful
map read.

Hello Adar, or anyone else affected,

Accepted autofs5 into maverick-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Hello Adar, or anyone else affected,

Accepted autofs5 into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

@Clint Byrum (clint-fewbar)

This issue is also seen in Natty, could we also see this in the natty-propose so we can validate if it fixes the issue?

Leonardo

This debdiff backports 52b4b907f4b41b09bde71da43b0325f4659d7e37 from upstream to the natty version.
This should fix it for natty.

Chris,

A couple of comments on your debdiff:

1- Could you change the version to 5.0.5-0ubuntu6.1
2- Could you add some tags to your patch to explain it's provenance (See http://dep.debian.net/deps/dep3/)

Thanks.

Fixed the changelog and added some tags to the patch.

Hi Chris

Thanks for the updated debdiff.

I've reviewed - I updated the changelog entry to have a bit more detail and uploaded to natty-proposed.

Cheers

James

@Chris/James

Could you please confirm which Lucid package version includes this fix in proposed?

Is the one below?
pool/main/a/autofs5/autofs5_5.0.4-3.1ubuntu5.2_amd64.deb

Leonardo

https://launchpad.net/ubuntu/+source/autofs5/5.0.4-3.1ubuntu5.2

Looks like you have the correct package.

In natty-proposed Unapproved queue, waiting on approval from ubuntu-sru

@jr / @james-page:

Can you give me a link to where the Natty package is published?

I was wondering if the natty patch has landed in -proposed yet?

Sorry for the delay in review. The changes look good, and I'm happy to accept them into -proposed, with the exception of the changelog; the changelog should be “human readable”, and so needs a brief summary of the user-visible behaviour it fixes (in addition to the bug link). Something along the lines of “Fixes orphaning of mounts when stopping autofs” would be fine.

I've rejected this from the natty-proposed queue; please upload again with the more verbose changelog.

@Chris

I've re-uploaded to natty-proposed with a much more verbose changelog entry.

@james
Cool thanks. Will make sure my changelogs are more verbose in the future. : )

Hello Adar, or anyone else affected,

Accepted autofs5 into natty-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

This doesn't look like it's fixed for me in natty:

$ grep autofs /proc/mounts | wc -l
361
$ sudo stop autofs
autofs stop/waiting
$ grep autofs /proc/mounts | wc -l
273
$ dpkg -l | grep autofs5
ii autofs5 5.0.5-0ubuntu6.1 kernel-based automounter for Linux, version 5
ii autofs5-ldap 5.0.5-0ubuntu6.1 LDAP map support for autofs, version 5
$ lsb_release -d
Description: Ubuntu 11.04

This problem needs additional patches that can be found in my related branch. My understanding is that testing with that patched autofs5 is proven positive. I will have an SRU written up once I receive a final confirmation today.

The merge proposal has been confirmed and verified on lucid.

The bug shouldn't be verified until after a package has been uploaded to -proposed and your branch, https://code.launchpad.net/~adam-stokes/ubuntu/lucid/autofs5/null-cache-remap-fix-578536/+merge/114664, hasn't made into -proposed as far as I can tell so I'm changing the tag back to verification-needed.

Additionally, comment 23 indicates that it failed on natty so it seems like it should also be fixed there.

The fix for this bug has been awaiting testing feedback in the -proposed repository for lucid for more than 90 days. Please test this fix and update the bug appropriately with the results. In the event that the fix for this bug is still not verified 15 days from now, the package will be removed from the -proposed repository.

The version of autofs5 in lucid-proposed has been removed as the bugs it was fixing (including this one) were not verified in a timely fashion.

maverick has seen the end of its life and is no longer receiving any updates. Marking the maverick task for this ticket as "Won't Fix".

natty has seen the end of its life and is no longer receiving any updates. Marking the natty task for this ticket as "Won't Fix".

lucid has seen the end of its life and is no longer receiving any updates. Marking the lucid task for this ticket as "Won't Fix".