Reload bug watches in bulk in checkwatches
Bug #572211 reported by
Gavin Panella
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Gavin Panella | ||
Bug Description
checkwatches hops in and out of database transactions a *lot*, for good reasons, but it also means that the database objects it has loaded from Storm need to be reloaded in every transaction. Storm takes care of this, but it reloads each object in turn, one at a time. If you have several hundred or thousand objects this can be punishing to the database, and can even end up dead at the hands of the transaction killer. It would be good to be able to reload objects in bulk.
Related branches
lp://staging/~allenap/launchpad/storm-bulk-reload-bug-572211
- Abel Deuring (community): Approve (code)
-
Diff: 227 lines (+218/-0)2 files modifiedlib/lp/services/database/bulk.py (+66/-0)
lib/lp/services/database/tests/test_bulk.py (+152/-0)
lp://staging/~allenap/launchpad/checkwatches-bulk-reload-bug-572211
- Abel Deuring (community): Approve (code)
-
Diff: 668 lines (+594/-4)3 files modifiedlib/lp/bugs/scripts/checkwatches/core.py (+5/-0)
lib/lp/bugs/scripts/tests/test_bugimport.py (+9/-4)
lib/lp/code/model/tests/test_sourcepackagerecipe.py (+580/-0)
| Changed in malone: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #1 |
| Changed in malone: | |
| milestone: | none → 10.05 |
| tags: | added: qa-needstesting |
Revision history for this message
| Graham Binns (gmb) wrote | #2 |
| tags: |
added: qa-untestable removed: qa-needstesting |
| Changed in malone: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r10892 <http://