Expose IBug.subscribe suppress_notify param via the API
Bug #571821 reported by
Deryck Hodge
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Brian Murray | ||
Bug Description
There was work done in bug 494257 to clean up the handling of notify calls so that users can be notified properly when subscribed by someone else. The param that was added to a bug's subscribe method was not exposed to the web service, though. Also, send_notifications should be true with all web service IBug.subscribe calls to prevent abuse.
Related branches
lp://staging/~brian-murray/launchpad/bug-571821
- Michael Nelson (community): Approve (code)
-
Diff: 84 lines (+15/-6)4 files modifiedlib/lp/bugs/interfaces/bug.py (+1/-1)
lib/lp/bugs/mail/tests/test_bug_subscribe.py (+13/-0)
lib/lp/bugs/stories/webservice/xx-bug.txt (+0/-4)
lib/lp/code/mail/tests/test_codehandler.py (+1/-1)
| tags: | added: dhrb |
| Changed in malone: | |
| assignee: | nobody → Brian Murray (brian-murray) |
| tags: | added: story-better-bug-notification |
Revision history for this message
| Brian Murray (brian-murray) wrote | #1 |
| Changed in malone: | |
| status: | Triaged → In Progress |
| summary: |
- Expose IBug.subscribe send_notifications param via the API + Expose IBug.subscribe suppress_notify param via the API |
Revision history for this message
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #2 |
| Changed in malone: | |
| milestone: | none → 10.06 |
| status: | In Progress → Fix Committed |
| tags: | added: qa-needstesting |
Revision history for this message
| Brian Murray (brian-murray) wrote | #3 |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in malone: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
It's actually suppress_notify should be False with all webservice subscribe calls.