oops signing CoC if keys mutate
Bug #555734 reported by
Curtis Hovey
This bug affects 4 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Edwin Grubbs | ||
Bug Description
oops OOPS-1556E1076 and 1545ED1138 failed because the user added a new gpgkey that was visible to part of launchpad, not not all launchpad. The template oopses because it uses a mix of python and tales code. The python code sees the new key, the tales does not. This is difficult to reproduce in dev, but we could make sure the template uses only one way access user/gpgkey
Related branches
lp://staging/~edwin-grubbs/launchpad/bug-555734-coc-oops
- Aaron Bentley (community): Approve
- Canonical Launchpad Engineering: Pending (code) requested
-
Diff: 155 lines (+84/-14)2 files modifiedlib/lp/registry/browser/tests/coc-views.txt (+67/-0)
lib/lp/registry/templates/codeofconduct-list.pt (+17/-14)
Revision history for this message
| Curtis Hovey (sinzui) wrote | #1 |
| Changed in launchpad-registry: | |
| assignee: | nobody → Edwin Grubbs (edwin-grubbs) |
| status: | Triaged → In Progress |
| Changed in launchpad-registry: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #2 |
| tags: | added: qa-needstesting |
| tags: |
added: qa-ok removed: qa-needstesting |
Revision history for this message
| Pavel Malyshev (afunix) wrote | #3 |
Revision history for this message
| Curtis Hovey (sinzui) wrote | #4 |
Revision history for this message
| Curtis Hovey (sinzui) wrote Bug 555734 Fix released | #5 |
| Changed in launchpad-registry: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
person.gpgkeys was renamed to person.gpg_keys. We are missing a test it seams.