Terminator

Compiles fails on preferences.glade not found

Bug #554760 reported by i.am.stack on 2010-04-03

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Terminator	Fix Released	Undecided	Chris Jones	Terminator 0.92 "redemption"

Bug Description

I have uploaded the attachment as well as posted to pastebin ( http://pastebin.com/EQgvwffa ) so I could reference line numbers and sections.

I just tried compiling the latest 0.91 on my CentOS 5.3 system and had a few failures.

$ cd ~/rpmbuild/SOURCES
$ wget -c http://launchpad.net/terminator/trunk/0.91/+download/terminator_0.91.tar.gz
$ cd ../SPECS/
$ tar -x terminator-0.91/terminator.spec -f ../SOURCES/terminator_0.91.tar.gz
$ rpmbuild -bp --target=`uname -m` terminator.spec
$ rpmbuild -bb --target=`uname -m` terminator.spec &> terminator.build

Line 517 is where preferences.glade is found missing. Line 529-536 is where the build fails.

Also, there is another possible related error on line 263-266 and it is reiterated on line 284-288.

I would appreciate it if someone could confirm this problem for me.
Thanks!

Revision history for this message

i.am.stack (i-am-stack) wrote on 2010-04-03:

Build output from CentOS 5.3 Edit (37.8 KiB, text/plain)

Revision history for this message

Chris Jones (cmsj) wrote on 2010-04-05:

Could you try editing the terminator.spec and removing line 55 please?

%{_datadir}/terminator/preferences.glade

I think that should fix that particular problem with the build.

Changed in terminator:
status:	New → Incomplete
assignee:	nobody → Chris Jones (cmsj)
importance:	Undecided → Medium
importance:	Medium → Undecided
milestone:	none → 0.92

Revision history for this message

i.am.stack (i-am-stack) wrote on 2010-04-05:

That fixed the rpmbuild command! I got no errors, few warnings, and rpm files! :-)

However, when I run terminator I get the other error still:
$ terminator
  File "/usr/bin/terminator", line 62
    finally:
          ^
SyntaxError: invalid syntax
$

:-/

Thanks for your time and help!

Revision history for this message

Chris Jones (cmsj) wrote on 2010-04-05:

i.am.stack: That sounds like you're running Python 2.4?

Changed in terminator:
status:	Incomplete → Fix Committed

Revision history for this message

Chris Jones (cmsj) wrote on 2010-04-05:

r966 contains an additional change that removes that particular piece of py2.4 incompatible syntax, although there may be others. I'd suggest a separate bug for any py24 issues.

Revision history for this message

i.am.stack (i-am-stack) wrote on 2010-04-06:

You are right. This probably should be a seperate issue. It was my mistake thinking it was related before. Sorry. I was just trying to bundle together everything that looked like it could have been causing problems.

I just checked and I am running 2.4
# yum list python.i386
Installed Packages
python.i386 2.4.3-27.el5 installed

A bit of googling shows that the official stance on the matter appears to be that 2.6 can cause system breakage on the current CentOS 5 unless python2.6 is installed completely seperately (running two versions concurrently). There are plenty of tutorials on how to do this so I will just follow one of those. It would be nice if I could get terminator running without 2.6, but I understand that it might be a bit much for you guys (I don't know how involved that will be as I don't know python that well but seeing as CentOS 6 should be showing up in a few months it may make a 2.4 patch obsolete). You may want to leave a note that python2.6 is required for any other CentOS 5 users though.

Feel free to close this bug.

Thanks for the bug fix, the help, and the information!

Revision history for this message

i.am.stack (i-am-stack) wrote on 2010-04-06:

Sorry. I accidently deleted a comment I shouldn't have.

I tried the r966 patch and I got other errors.

This is why I am going to work on the 2.6 install. If you want me to file a seperate bug report let me know, but again, with RHEL 6 supposedly entering beta soon (and CentOS 6 short on its heels) it may make any patches for 2.4 obsolete.

Thanks again for the help! I do appreciate it.

Chris Jones (cmsj) on 2010-04-08