widelands

Can't compile since 5159

Bug #554461 reported by Iain McFarlane
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Critical
Victor Pelt
widelands build15

Bug Description

[ 10%] Building CXX object src/CMakeFiles/widelands_main.dir/wlapplication.cc.o
/home/iain/src/widelands/src/wlapplication.cc: In function ‘void terminate(int)’:
/home/iain/src/widelands/src/wlapplication.cc:951: error: ‘SIGKILL’ was not declared in this scope
/home/iain/src/widelands/src/wlapplication.cc:951: error: ‘raise’ was not declared in this scope
/home/iain/src/widelands/src/wlapplication.cc: In member function ‘void WLApplication::shutdown_hardware()’:
/home/iain/src/widelands/src/wlapplication.cc:975: error: ‘SIGALRM’ was not declared in this scope
/home/iain/src/widelands/src/wlapplication.cc:975: error: ‘signal’ was not declared in this scope
make[2]: *** [src/CMakeFiles/widelands_main.dir/wlapplication.cc.o] Error 1

Revision history for this message
Iain McFarlane (iain-imcfarla) wrote :

Sorry should have added this to the initial report

Trying to compile on Ubuntu Lucid

Revision history for this message
Victor Pelt (victor-pelt) wrote :

what glibc and gcc version are you using?

Changed in widelands:
milestone: none → build15
assignee: nobody → Dwarik (victor-pelt)
importance: Undecided → Critical
status: New → Incomplete
status: Incomplete → Triaged
status: Triaged → In Progress
Revision history for this message
Victor Pelt (victor-pelt) wrote :

could you add "#include <signal.h>" on top of wlapplication.cc and report if that fixes it. since i'm not having this issue i also would still like to know which glibc and gcc version you are using

Revision history for this message
Iain McFarlane (iain-imcfarla) wrote :

I hope this helps

libglib2.0-0 2.24.0-0ubuntu1
gcc 4:4.4.3-1ubuntu1
libc6 2.11.1-0ubuntu5

yes adding it to the top of wlapplication.cc does fix it

Revision history for this message
SirVer (sirver) wrote :

remember to add a #ifndef WIN32 around. I will test if things still compile on mac os x.

Revision history for this message
Victor Pelt (victor-pelt) wrote :

not convinced windows shouldn't pick it up if proper headers are included but just in case
fixed in rev 5184

Changed in widelands:
status: In Progress → Fix Committed
Revision history for this message
SirVer (sirver) wrote :

windows has no POSIX signals imho.

Revision history for this message
Jari Hautio (jarih) wrote :

Just saw this bug so just to clear up windows side: Windows (MSVC) has signal.h header and but it does not define SIGKILL or SIGALRM signals. I already added WIN32 ifdefs to appropriate places in r5180.

Revision history for this message
SirVer (sirver) wrote :

Released in build-15

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.