OpenShot Video Editor

Error in export to Image Sequence when using localisation

Bug #551209 reported by Clemens Rabe on 2010-03-29

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenShot Video Editor	Fix Released	High	Jonathan Thomas	OpenShot Video Editor 1.2.0

Bug Description

OS: Gentoo Linux (32Bit and 64Bit)
Installation Method: Own ebuild
OpenShot Version 1.1.1
MLT: 0.5.2

In the ExportWindow.py file, the combo box is filled with translated strings, but later on in video.py, the english versions are tested. The attached patch fixes this problem by translating the strings back to english.

Also, the form is validated for "Video & Audio" and "Image Sequence" differently now.

In addition, I've added the "none" audio codec, that allows the export to a video without an audio track.

Cheers,
Clemens Rabe

Tags:

Related branches

lp://staging/openshot/1.4

Revision history for this message

Clemens Rabe (clemens-rabe) wrote on 2010-03-29:

Patch to fix the mentioned problem, add the "none" audio codec and validate the form according to the export type. Edit (4.0 KiB, text/plain)

Revision history for this message

Olivier Girard (eolinwen) wrote on 2010-03-30:

Thanks for the patch. It will be included in the next version after having tested it.

moimael (moimael) on 2010-04-03

Changed in openshot:
status:	New → Confirmed
importance:	Undecided → Medium

moimael (moimael) on 2010-05-27

Changed in openshot:
milestone:	none → 1.2.0

Jonathan Thomas (jonoomph) on 2010-07-04

Changed in openshot:
assignee:	nobody → Jonathan Thomas (jonoomph)
importance:	Medium → High
status:	Confirmed → In Progress

Revision history for this message

Jonathan Thomas (jonoomph) wrote on 2010-07-04:

Clemens,
I was unable to apply the patch, but I used it as a guide. Instead of change the translated text "Image Sequence" back to English, I fixed the core issue in our video.py thread. All of the validations are now specific to "Video & Audio" or "Image Sequence", and all validations and settings now work in all languages.

Also, I added the 'none' audio code, which also seemed to work fine in all languages.

Thanks for the help!
-Jonathan