Crash on selecting revision 1, mentioning bzrlib.lazy_import.ImportReplacer

Bug #551142 reported by Max Bowsher
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
QBzr
Fix Released
Medium
Gary van der Merwe

Bug Description

Run 'bzr qlog' in any branch or shared repo. Scroll down to revno 1. Click it.

There will be an exception thrown (it varies depending on the kind of branch, whether you're qlogging 1 or multiple branches) mentioning <bzrlib.lazy_import.ImportReplacer object at 0x........>.

The problem is that logwidget.py lazy-imports NULL_REVISION, and subsequently puts it into data structures. According to the doc-comment of bzrlib.lazy_import, lazy-importing constants is almost never the right thing to do. Making the NULL_REVISION import into a non-lazy import fixes the problem.

Tags: qlog
Changed in qbzr:
status: New → Confirmed
importance: Undecided → Medium
tags: added: qlog
Changed in qbzr:
assignee: nobody → Gary van der Merwe (garyvdm)
milestone: none → 0.19b1
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.