Initscript does not enable timesync, misses status option

Bug #545903 reported by born2chill
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
open-vm-tools (Ubuntu)
Confirmed
Wishlist
Unassigned

Bug Description

Binary package hint: open-vm-tools

Description: Ubuntu lucid (development branch)
Release: 10.04
Package: open-vm-tools [2010.02.23-236320-1+ubuntu1]

The open-vm-tools are missing an option to enable the host-to-vm timesync, which can be activated via the "vmware-toolbox-cmd"-command. Also the init-script doesn't have a 'status' option, which is always nice to have (monitoring etc...). Both options are missing at the moment.

Tags: patch
Revision history for this message
born2chill (david-gabriel) wrote :
Changed in open-vm-tools (Ubuntu):
assignee: nobody → Ubuntu Virtualisation team (ubuntu-virt)
description: updated
Revision history for this message
Cristian Măgherușan-Stanciu (cristi) wrote :

Please anyone test and merge the proposed changes, especially the one about initscript status .
Missing status breaks Puppet's service monitoring functionality, so the service will be restarted at each Puppet execution.

Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Hi! Thanks for the feature request and suggested patch! I've confirmed this doesn't exist on Oneiric still. Marking as Confirmed, priority Wishlist. Also tagging 'patch' and subscribing Ubuntu review team so they can take a closer look at your suggested updates. It would be most useful if you submitted it as a merge proposal or debdiff:

https://wiki.ubuntu.com/PackagingGuide/Complete#Creating a Debdiff

Changed in open-vm-tools (Ubuntu):
status: New → Confirmed
importance: Undecided → Wishlist
assignee: Ubuntu Virtualisation team (ubuntu-virt) → nobody
tags: added: patch
Revision history for this message
pguinardco (pguinardco) wrote :

Here is a diff for adding status in current /etc/init.d/open-vm-tools:

--- /etc/init.d/open-vm-tools 2015-05-20 09:17:41.825174249 -0600
+++ /etc/init.d/open-vm-tools.fixed 2015-05-20 09:17:31.536821914 -0600
@@ -47,6 +47,9 @@
                ${0} stop
                ${0} start
                ;;
+ status)
+ status_of_proc -p /var/run/vmtoolsd.pid && exit 0 || exit $?
+ ;;
        *)
                log_success_msg "Usage: ${0} {start|stop|restart|force-reload}"
                exit 1

Revision history for this message
pguinardco (pguinardco) wrote :

EDIT:
--- /etc/init.d/open-vm-tools 2015-05-20 09:17:41.825174249 -0600
+++ /etc/init.d/open-vm-tools.fixed 2015-05-20 09:17:31.536821914 -0600
@@ -47,6 +47,9 @@
                ${0} stop
                ${0} start
                ;;
+ status)
+ status_of_proc -p /var/run/vmtoolsd.pid vmtoolsd && exit 0 || exit $?
+ ;;
        *)
                log_success_msg "Usage: ${0} {start|stop|restart|force-reload}"
                exit 1

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.