mpd.py produces crash when confronted with invalid entry in year tag of the mp3

Bug #539128 reported by g4v4g4i
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
CoverGloobus
Fix Released
Undecided
Unassigned

Bug Description

The following traceback is produced when playing a file with mp3-date not being an integer but "2010-03-05":
"Traceback (most recent call last):
  File "/usr/share/covergloobus/covergloobus.py", line 680, in <module>
    sys.exit(cg.main())
  File "/usr/share/covergloobus/covergloobus.py", line 107, in main
    self.init() #Init configurations
  File "/usr/share/covergloobus/covergloobus.py", line 130, in init
    self.init_player()
  File "/usr/share/covergloobus/covergloobus.py", line 170, in init_player
    self.track = self.player.get_track()
  File "/usr/share/covergloobus/players/MPD.py", line 100, in get_track
    cover = self.search_cover(data['file'],data))
  File "/usr/share/covergloobus/common.py", line 164, in __init__
    self.year = int(year)
ValueError: invalid literal for int() with base 10: '2010-03-05'"

I think it would be preferable that the app doesn't crash confronted with a not perfectly well tagged mp3s but that the information of the wrong entry is rather ignored. I guess most users don't have a perfectly well tagged database.

Best,
Christian

Tags: mpd mpd.py tag
Changed in covergloobus:
assignee: nobody → Jaap Broekhuizen (jaapz-b)
Revision history for this message
Jaap Broekhuizen (jaapz-b) wrote :

This is already fixed in bzr.

Changed in covergloobus:
assignee: Jaap Broekhuizen (jaapz-b) → nobody
status: New → Fix Committed
milestone: none → 1.7
Changed in covergloobus:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.