mail applet update interval keeps resetting

Bug #533874 reported by Sérgio Faria
22
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Awn Extras
Fix Released
Medium
onox

Bug Description

The update interval keeps reseting on reboots to 0 mins, atleast with gmail. I also suspect that when its set for ex 5 mins interval, it continues updating at the default rate.

Using the trunk version from the repository: 0.3.9.1.1~bzr1212-19.10 on ubuntu 9.10

Tags: applet mail

Related branches

Michal Hruby (mhr3)
Changed in awn-extras:
assignee: nobody → Grega Podlesek (muscardinus)
importance: Undecided → Low
milestone: none → 0.4.0
Michal Hruby (mhr3)
Changed in awn-extras:
milestone: 0.4.0 → 0.4.2
Changed in awn-extras:
assignee: Grega Podlesek (muscardinus) → MisterBlack (thesympsons)
Revision history for this message
MisterBlack (thesympsons) wrote :

First of all, I'm really, really new at python, but I'm a developer, so I started digging on this bug to try to learn a bit.

The attachment is the mail.py file that fixes this bug (I've tested it and it's working)

Please comment anything you want, and remember I don't know python, I'm just a learner :)

Changed in awn-extras:
assignee: MisterBlack (thesympsons) → nobody
Revision history for this message
MisterBlack (thesympsons) wrote :

I'm sorry, but I've never made a patch before. Here it is

Changed in awn-extras:
assignee: nobody → MisterBlack (thesympsons)
Revision history for this message
onox (onox) wrote :

You can generate a patch by calling bzr diff applets/maintained/mail/mail.py in your checkout/branch of awn-extras.

I think you should change the body of changed_timeout_cb to:
value = spinbutton.get_value()
self.awn.settings["timeout"] = value
self.timer.change_interval(value * 60)

Changed in awn-extras:
status: New → In Progress
tags: removed: interval resets update
Revision history for this message
MisterBlack (thesympsons) wrote :

Yeah, you're right, that should update the timeout without restarting the applet.

As I said, I'm really new at this and I'm not using any revision control system (yet). I'm used to work with subversion, but I'm not really familiar with linux repositories. If you could help me with that I would be very grateful.

Anyway, thanks for reviewing the code, I attach the modified patch (made using diff)

Revision history for this message
onox (onox) wrote :

You can do bzr branch lp:awn-extras or bzr checkout. Then you can do bzr stat to see what has changed. bzr log and bzr diff are also quite useful. To be on-topic: I think more elements in the preferences window aren't working anymore. setup_preferences() should be refactored to use the config binder (see setup_preferences() in for example weather/weather.py)

Revision history for this message
onox (onox) wrote :

Fixed in revision 1327.

Changed in awn-extras:
assignee: MisterBlack (thesympsons) → onox (onox)
importance: Low → Medium
status: In Progress → Fix Committed
Povilas Kanapickas (p12)
Changed in awn-extras:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.