QBzr

qconfig should not add quotes around editor path

Bug #523212 reported by Casufi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
QBzr
Fix Released
High
Alexander Belchenko
QBzr 0.18.2 "Cedar"

Bug Description

I am trying to use notepad++ as editor for bzr.
I tried to set a path "C:\Program Files\Notepad++\notepad++.exe" using bzr qconfig and I got the following config file

[DEFAULT]
email = <email address hidden>
editor = '"C:/Program Files/Notepad++/notepad++.exe"'
mail_client = default
[ALIASES]

Tags: qconfig

Related branches

lp://staging/qbzr/0.18
Revision history for this message
Gary van der Merwe (garyvdm) wrote :

I can't see what the bug is. This seems correct.

What did you expect it to do?

Changed in qbzr:
status: New → Incomplete
Revision history for this message
Casufi (vladimirkotulskiy) wrote :

The path to an editor contains double and single quotes at the same time

Revision history for this message
Gary van der Merwe (garyvdm) wrote :

Does it launch the editor correctly though?

Revision history for this message
Casufi (vladimirkotulskiy) wrote :

Here is an error message

D:\Develop\GFK TimeTable>bzr commit --unchanged --local
Committing to: D:/Develop/GFK TimeTable/
aborting commit write group: WindowsError(123, '\xd1\xe8\xed\xf2\xe0\xea\xf1\xe8\xf7\xe5\xf1\xea\xe0\xff \xee\xf8\xe8\xe1\xea\xe0 \xe2 \xe8\xec\xe5\xed\xe8 \xf4\xe0\xe9\xeb\xe0,')

bzr: ERROR: [Error 123] Синтаксическая ошибка в имени файла,

Here is wrong string
editor = '"C:/Program Files/Notepad++/notepad++.exe"'

Here is correct string
editor = "C:/Program Files/Notepad++/notepad++.exe"

Gary van der Merwe (garyvdm)
summary: - set long filename for editor using bzr qconfig
+ qconfig should not add ' quote around editor path
tags: added: qconfig
Changed in qbzr:
importance: Undecided → High
status: Incomplete → Confirmed
Revision history for this message
Casufi (vladimirkotulskiy) wrote : Re: qconfig should not add ' quote around editor path

Thank you. Sorry for my bad English.

Revision history for this message
Alexander Belchenko (bialix) wrote :

Gary, I know what the problem here, we discussed it in ru_bzr. I've made quoting change in the past, I will rollback it now.

Changed in qbzr:
assignee: nobody → Alexander Belchenko (bialix)
milestone: none → 0.18.2
summary: - qconfig should not add ' quote around editor path
+ qconfig should not add quotes around editor path
Alexander Belchenko (bialix)
Changed in qbzr:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.