Canonical SSO provider

Make list of previous sites into clickable links

Bug #522829 reported by Stuart Metcalfe
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical SSO provider
Fix Released
Wishlist
David Owen
Canonical SSO provider 2.7.0

Bug Description

When logged in to login.ubuntu.com, the list of sites you previously logged into could include clickable links.

Testcase added to ISD_201

See original description

Related branches

lp://staging/~canonical-isd-hackers/canonical-identity-provider/bug_522829_site_links
Anthony Lenton (community): Approve
Diff: 80 lines (+14/-5)
5 files modified
doctests/runner.py (+2/-1)
doctests/stories/sso-server/home-page.txt (+6/-0)
doctests/stories/sso-server/license.txt (+0/-3)
doctests/utils.py (+5/-0)
identityprovider/templates/widgets/last_auth_sites.html (+1/-1)
Revision history for this message
Stuart Metcalfe (stuartmetcalfe) wrote :

We need to confirm that those urls (actually 'trust roots') will always be user-accessible sites. I think they are but need to confirm

Stuart Metcalfe (stuartmetcalfe)
Changed in canonical-identity-provider:
milestone: none → 2.6.0
Revision history for this message
Stuart Metcalfe (stuartmetcalfe) wrote :

Should we consider having a departure page with a suitable notice about canonical not being responsible for external sites' content if the URL isn't a known trust root?

Revision history for this message
Stuart Metcalfe (stuartmetcalfe) wrote :

Also, if the site is a known trust root (eg: "Ubuntu One") we could use its name from the rpconfig data rather than the url as the link label

Revision history for this message
Julien Funk (jaboing) wrote :

Note to QA: When this is complete it will need at least one test case associated with it as well as functional clarifications.

Changed in canonical-isd-qa:
assignee: nobody → Dave Morley (davmor2)
Łukasz Czyżykowski (lukasz-czyzykowski)
Changed in canonical-identity-provider:
milestone: 2.6.0 → 2.7.0
Revision history for this message
David Owen (dsowen) wrote :

Was a decision made about a departure page?

Revision history for this message
Stuart Metcalfe (stuartmetcalfe) wrote :

Let's not have a departure page for now. We can assume the user has been to the site at least once and therefore knows something about it.

David Owen (dsowen)
Changed in canonical-identity-provider:
assignee: nobody → David Owen (dsowen)
status: Confirmed → In Progress
David Owen (dsowen)
Changed in canonical-identity-provider:
status: In Progress → Fix Committed
Revision history for this message
Dave Morley (davmor2) wrote :

This is working on EC2

Changed in canonical-isd-qa:
status: New → Confirmed
Dave Morley (davmor2)
description: updated
Revision history for this message
Julien Funk (jaboing) wrote :

Pass on Staging.

Changed in canonical-isd-qa:
status: Confirmed → Fix Committed
Revision history for this message
Dave Morley (davmor2) wrote :

Passes on Production

Changed in canonical-isd-qa:
status: Fix Committed → Fix Released
Danny Tamez (zematynnad)
Changed in canonical-isd-qa:
milestone: none → canonical-identity-provider+2.7.0
Ricardo Kirkner (ricardokirkner)
Changed in canonical-identity-provider:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.