Mixxx

Mixxx 1.8 beta1 hotcue saving error and crash when using Track editor

Bug #518101 reported by jus on 2010-02-06

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Mixxx	Fix Released	High	RJ Skerry-Ryan	Mixxx 1.8.0

Bug Description

Step 1
Load mp3, set one ore more Hotcues to the track.

Step 2
Close and reopen Mixxx, select same track and open Trackeditor via right-click.

Actual Result
*Only one Hotcue (even when more are set) is shown with the wrong position
*When editing or adding Hotcue via Trackeditor Mixxx`crash.

Expected Result
* All Hotcues to be shown with the correct position
* All Hotcues editable without hang and crash

See screenshot & crashlog

Tags:

Revision history for this message

jus (jus) wrote on 2010-02-06:

Mixxx1.8beta1_hotcue_edit_bug.png Edit (102.5 KiB, image/png)

Revision history for this message

jus (jus) wrote on 2010-02-06:

Mixxx1.8beta1_hotcue_edit_bug.txt Edit (25.4 KiB, text/plain)

RJ Skerry-Ryan (rryan) on 2010-02-06

Changed in mixxx:
assignee:	nobody → RJ Ryan (rryan)
status:	New → Confirmed
milestone:	none → 1.8.0
importance:	Undecided → High
tags:	added: crash
tags:	added: hotcue

Revision history for this message

RJ Skerry-Ryan (rryan) wrote on 2010-02-18:

This should be fixed now. Verified fine for me on the Deere skin -- hotcues in the overview line up with their actual position now and the track information dialog shows them properly and doesn't crash when you click apply.

Changed in mixxx:
status:	Confirmed → Fix Committed

Revision history for this message

jus (jus) wrote on 2010-02-18:

lp518101.png Edit (213.1 KiB, image/png)

Nice,the crash is gone :-) But there may some minor errors left.

Track information dialog:
*Position for (Hot)cues is shown twice the actual value. A (Hot)cue set at 0:10.00 shows up as 0:20.00.
*You can not delete or activate (Hot)Cues via the the corresponding buttons in track information dialog.
*If a (Hot)cue is deleted via GUI, the position remains in the database. Only the (Hot)cue number is set to -1.

see screenshot

Revision history for this message

RJ Skerry-Ryan (rryan) wrote on 2010-02-18:

Hey Jus,

I just fixed the doubled-position issue and the delete button. I don't think that activate will work for this release because it's ambiguous which deck the person means for it to play on. (the same track could be loaded in both decks). I'll probably remove it.

Not sure if you noticed, but in trunk no changes to tracks or cues save. I revived the features-sqlite branch to fix this problem mixxx-wide.

When you delete a hotcue via hotcue_xxx_clear, it just resets the cue's hotcue to -1. This is intentional so that if you spent time setting up your tracks hotcue's (adding labels, etc), then accidentally right-clicking a hotcue button will never actually delete it. The track info dialog shouldn't show the -1 though, it should just show it as blank.

Thanks,
RJ

Revision history for this message

Phillip Whelan (pwhelan) wrote on 2010-06-30: Re: [Bug 518101] Re: Mixxx 1.8 beta1 hotcue saving error and crash when using Track editor

You're removing hotcue_xxx_activate ??!?!?!

Revision history for this message

RJ Skerry-Ryan (rryan) wrote on 2010-07-07:

nope, not removing hotcue_xxx_activate, possibly removing the 'Activate' button in hte track dialog :)

RJ Skerry-Ryan (rryan) on 2010-10-05