OpenShot Video Editor

keyboard shortcuts with CTRL or SHIFT do not work unless "bloc num" on keyboard is active

Bug #514317 reported by hva
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenShot Video Editor
Fix Released
Low
Jonathan Thomas
OpenShot Video Editor 1.1.0

Bug Description

It seems that key bindings with CTRL do not get processed correctly unless "bloc num" key is activated on keyboard

hva (francesco-hermanitosverdes)
Changed in openshot:
importance: Undecided → Low
Revision history for this message
hva (francesco-hermanitosverdes) wrote :

actual code is:
   elif keyname == "z":
    # undo
    if event.state == gtk.gdk.CONTROL_MASK | gtk.gdk.MOD2_MASK:
     self.on_tlbUndo_clicked(widget)

that doesn't work if bloc_num on keyboard is not activated.

how about using simply

if event.state == gtk.gdk.CONTROL_MASK

this works on my system, but could this cause problems in some configuration?

Jonathan Thomas (jonoomph)
Changed in openshot:
milestone: none → 1.1.0
assignee: nobody → Jonathan Thomas (jonoomph)
status: New → Confirmed
Revision history for this message
Jonathan Thomas (jonoomph) wrote :

@hva, the code snipped you provided only works if the "num lock" is off, and the original code only worked if the "num lock" was turned on. So, after a bit of trial and error, I have found a syntax that seems to work regardless of "num lock". This fix has been committed to the trunk. Thanks!

Changed in openshot:
status: Confirmed → Fix Committed
moimael (moimael)
Changed in openshot:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.